Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in video library controller #93

Open
foolhardy21 opened this issue Mar 22, 2022 · 2 comments
Open

Bug in video library controller #93

foolhardy21 opened this issue Mar 22, 2022 · 2 comments

Comments

@foolhardy21
Copy link

  • This issue is regarding the getVideosFromPlaylistHandler() which takes the playlistId from the request params and returns the respective playlist.

  • However, the current logic of find() gives back the playlist that does not match the playlistId given in the params. Here is the screenshot.
    bug

  • This can be fixed by checking for strict equality between playlistId and item._id

  • Kindly confirm.

@Launchpad5682
Copy link

You need to change !== to ===.

@foolhardy21
Copy link
Author

foolhardy21 commented Mar 22, 2022

You need to change !== to ===.

Yes I did that. I thought of mentioning this issue here but i guess I'll create a PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants