Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a NotaryAssisted transaction attribute #2896

Open
roman-khimov opened this issue Sep 6, 2023 · 0 comments · May be fixed by #3175
Open

Add a NotaryAssisted transaction attribute #2896

roman-khimov opened this issue Sep 6, 2023 · 0 comments · May be fixed by #3175
Labels
Discussion Initial issue state - proposed but not yet accepted
Milestone
v3.8.0

Comments

@roman-khimov
Copy link
Contributor

Summary or problem description
Add a new transaction attribute, NotaryAssisted with all of the associated logic from #1573 (comment)

Do you have any solution you want to propose?
Change 50 lines of the code and let this attribute exist. Notary contract mechanics should be stubbed at this point (wrt dynamic fee value (can be static 0.1) and signer checks).

Target Neo Version

  • Neo 3.7

Where in the software does this update applies to?

  • P2P (TCP)
@roman-khimov roman-khimov added the Discussion Initial issue state - proposed but not yet accepted label Sep 6, 2023
@roman-khimov roman-khimov mentioned this issue Sep 6, 2023
Open
This was referenced Sep 14, 2023
Closed
Merged
@AnnaShaleva AnnaShaleva mentioned this issue Nov 8, 2023
Closed
@roman-khimov roman-khimov added this to the v3.7.0 milestone Nov 16, 2023
@roman-khimov roman-khimov mentioned this issue Nov 21, 2023
Merged
1 task
@AnnaShaleva AnnaShaleva mentioned this issue Mar 3, 2024
Open
AnnaShaleva added a commit to AnnaShaleva/neo that referenced this issue Mar 6, 2024
@AnnaShaleva
Implement NotaryAssisted transaction attribute
cfb2842 
Close neo-project#2896. Use a stub for native Notary contract hash since this
contract is not implemented yet. Thus, technically, NotaryAssisted
attribute verification will always fail on real network until native
Notary implementation.

Signed-off-by: Anna Shaleva <[email protected]>
AnnaShaleva added a commit to AnnaShaleva/neo that referenced this issue Mar 6, 2024
@AnnaShaleva
Implement NotaryAssisted transaction attribute
ebe0f6d 
Close neo-project#2896. Use a stub for native Notary contract hash since this
contract is not implemented yet. Thus, technically, NotaryAssisted
attribute verification will always fail on real network until native
Notary is implemented.

Signed-off-by: Anna Shaleva <[email protected]>
AnnaShaleva added a commit to AnnaShaleva/neo that referenced this issue Mar 6, 2024
@AnnaShaleva
Implement NotaryAssisted transaction attribute
6da4ae2 
Close neo-project#2896. Use a stub for native Notary contract hash since this
contract is not implemented yet. Thus, technically, NotaryAssisted
attribute verification will always fail on real network until native
Notary is implemented.

Signed-off-by: Anna Shaleva <[email protected]>
@AnnaShaleva AnnaShaleva linked a pull request Mar 6, 2024 that will close this issue
Open
12 tasks
AnnaShaleva added a commit to AnnaShaleva/neo-devpack-dotnet that referenced this issue Mar 6, 2024
@AnnaShaleva
Add NotaryAssisted transaction attribute type
24c6641 
Port neo-project/neo#3175.
Ref. neo-project/neo#2896.

Signed-off-by: Anna Shaleva <[email protected]>
@AnnaShaleva AnnaShaleva mentioned this issue Mar 6, 2024
Open
AnnaShaleva added a commit to AnnaShaleva/neo-modules that referenced this issue Mar 6, 2024
@AnnaShaleva
Add NotaryAssisted transaction attribute type
8f55314 
Port neo-project/neo#3175.
Ref. neo-project/neo#2896.

Signed-off-by: Anna Shaleva <[email protected]>
@AnnaShaleva AnnaShaleva mentioned this issue Mar 6, 2024
Closed
@AnnaShaleva AnnaShaleva mentioned this issue Apr 8, 2024
Merged
@roman-khimov roman-khimov modified the milestones: v3.7.0, v3.8.0 May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Discussion Initial issue state - proposed but not yet accepted
Projects
None yet
Milestone
v3.8.0
Development

Successfully merging a pull request may close this issue.

Implement NotaryAssisted transaction attribute AnnaShaleva/neo
1 participant
@roman-khimov