Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace modbus NO_READING -9999 with less upsetting value #180

Open
neilh10 opened this issue Dec 5, 2024 · 0 comments
Open

Replace modbus NO_READING -9999 with less upsetting value #180

neilh10 opened this issue Dec 5, 2024 · 0 comments

Comments

@neilh10
Copy link
Owner

neilh10 commented Dec 5, 2024

Modbus Insitu LT500 depth sensors in the field are periodically downloaded by site hydrology crew when performing local visits. This can result in a hardcoded inband error default -9999 reading, which then causes knock on effect with the ODM2/MMW automatic scaling.
Different sensors have different ranges, and so its challenging to indicate and
Change default to value that causes less problems for the automatic scaling
For the modbus sensor hardcoded defaults are in InsituParent.cpp there are three readings
waterPressureBar - theoritically can never have negative depth use magic number -0.09876
waterTemperature - unlikely to ever indicate large negative temperature --> use -9.876
waterDepthM --> (theoritically can never have negative depth) use magic number -0.09876
Due to where sensors readings are organized this affects lib InsituModbus where readings are taken
and src/InsituParent.cpp where reading is initiated from.

Update the similar sensor KellerParent.cpp and lib KellerModbus
This is a specific sensor update, the following was listed as a system wide update 18months ago, and nothing has happened since then:
EnviroDIY#443

neilh10 pushed a commit to neilh10/InsituModbus that referenced this issue Dec 5, 2024
neilh10 pushed a commit to neilh10/KellerModbus that referenced this issue Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant