Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RegexError: Every tab "Null" after clicking individual core (MacOS) #313

Closed
kitchentongue opened this issue Sep 12, 2024 · 3 comments · Fixed by #315
Closed

RegexError: Every tab "Null" after clicking individual core (MacOS) #313

kitchentongue opened this issue Sep 12, 2024 · 3 comments · Fixed by #315
Labels
bug Something isn't working

Comments

@kitchentongue
Copy link

When I first connect my Pocket's SD card to Sync, it will recognize it and load as usual. I can view all my cores, see my savestates, etc. But after trying to click on any core individually, it will throw a "Null" error that then persists on every other tab. Even after hitting the "retry" button it will never load the core / load any other tab I attempt to access. Tried uninstalling and reinstalling Pocket Sync, made sure my Pocket's firmware was up to date, and the issue will still trigger. Error readout below:

Invalid regular expression: invalid group specifier name
RegExp@[native code]
p@tauri://localhost/assets/index-CM7525Ey.js:52:17044
r@tauri://localhost/assets/index-CM7525Ey.js:42:4604
ap@tauri://localhost/assets/index-CM7525Ey.js:52:13453
ghttps://github.com/tauri://localhost/assets/index-B3ZZMOkK.js:39:17021
Ww@tauri://localhost/assets/index-B3ZZMOkK.js:41:44047
Vw@tauri://localhost/assets/index-B3ZZMOkK.js:41:39779
X2@tauri://localhost/assets/index-B3ZZMOkK.js:41:39707
ch@tauri://localhost/assets/index-B3ZZMOkK.js:41:39559
yg@tauri://localhost/assets/index-B3ZZMOkK.js:41:35923
Uw@tauri://localhost/assets/index-B3ZZMOkK.js:41:34872
Uw@[native code]
E@tauri://localhost/assets/index-B3ZZMOkK.js:26:1551
oe@tauri://localhost/assets/index-B3ZZMOkK.js:26:1914

After removing SD card, Pocket still functions as expected.

MacOS Ventura

Not super urgent, just trying to enable that new screenfilter for budude's GB core lol.

@kitchentongue kitchentongue added the bug Something isn't working label Sep 12, 2024
@neil-morrison44
Copy link
Owner

Ah, Ventura.

I think I know what’s going wrong, some dependency will have updated with a lookbehind regex & the WebKit version in Ventura doesn’t support that.

I’ll have a look through the built code to try and work out what’s updated to do that…

@neil-morrison44 neil-morrison44 changed the title Every tab "Null" after clicking individual core (MacOS) RegexError: Every tab "Null" after clicking individual core (MacOS) Sep 12, 2024
@neil-morrison44
Copy link
Owner

Found it, this line was changed in a dependency 4 dependencies deep and it introduced a RegExp lookbehind which isn't supported in Safari versions before 16 (which is what the app uses when run on MacOS Ventura).

https://github.com/syntax-tree/mdast-util-gfm-autolink-literal/blob/main/lib/index.js#L135

I'll put a fix in since I try to keep it running on the last 2 versions of macOS & macOS Sequoia is still 3 days away...

Can see more in their issue here:
syntax-tree/mdast-util-gfm-autolink-literal#10

(I agree with them not wanting to fix it, for the record)

@Threeethan
Copy link

Came back to check on this after I had trouble yesterday - wow, thank you for getting to the bottom of this so quickly. Working beatifully now for me.

@neil-morrison44 neil-morrison44 mentioned this issue Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants