Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizable TimelineEditorTrack action icons #9

Open
argorain opened this issue Dec 10, 2020 · 3 comments
Open

Customizable TimelineEditorTrack action icons #9

argorain opened this issue Dec 10, 2020 · 3 comments

Comments

@argorain
Copy link
Contributor

Hi!

I see there is lot of new stuff in master (thank you!) and one of them are action icons for dragging, scaling and menu. Frankly, it took me just too long to figure it out. It's due drag action icon is same as scale action icon. I couldn't find how to drag box and had to debug it to see what I am doing wrong. Maybe just replacing it with https://material.io/resources/icons/?search=drag&icon=drag_indicator&style=baseline would be enough.

See it before and after

I think there should be some way how to modify those icons to match general app look and feel and right now there is only way modify plugin sources directly. If you decide not to give users this level of control, then we should at least fix those icons.

Thank you and keep up doing great job!

Vojtech

P.S. I can do those modifications and submit PR if we agree to do them.

@argorain
Copy link
Contributor Author

As I am digging more and more int this, I am now convinced that icons must be configurable. User can do anything in those callbacks.

@neckaros
Copy link
Owner

Thanks very much for your contribution. I release a first preview version with your dev included:
https://pub.dev/packages/timeline_editor/versions/0.4.0-preview.1
There was a lot of rewrite so i need more time to test. Unfortunately since COVID i have very little :(

@argorain
Copy link
Contributor Author

No problem mate, it's tough time for everyone. Thanks for releasing preview version :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants