Execution of commands that throw exceptions should not return a success. #2

scrain · 2016-06-24T19:21:16Z

It looks like the intent of GitProvider.grgitCommand is to return false if an exception is encountered, but as currently written it will always return true.

gerhard6 · 2016-12-07T12:16:51Z

also, it would be helpful, if the related Exception would be logged completely (including the cause chain), and not only it's message. It is very hard to find the reason, why e.g a push operation fails.

scrain mentioned this issue Jun 24, 2016

Make GrGit exceptions return false result (issue #2) #3

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Execution of commands that throw exceptions should not return a success. #2

Execution of commands that throw exceptions should not return a success. #2

scrain commented Jun 24, 2016

gerhard6 commented Dec 7, 2016 •

edited

Loading

Execution of commands that throw exceptions should not return a success. #2

Execution of commands that throw exceptions should not return a success. #2

Comments

scrain commented Jun 24, 2016

gerhard6 commented Dec 7, 2016 • edited Loading

gerhard6 commented Dec 7, 2016 •

edited

Loading