Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

view_state should not be limited to 101 keys #144

Closed
frol opened this issue Dec 12, 2023 · 1 comment
Closed

view_state should not be limited to 101 keys #144

frol opened this issue Dec 12, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@frol
Copy link
Collaborator

frol commented Dec 12, 2023

With the current implementation:

let keys_count = data.keys().len() as u8;
if keys_count > MAX_LIMIT {
return data;

view_state method truncates the output to 101 keys. How heavy would it be to allow up to 10k keys and, ideally, implement pagination?

cc @khorolets

@frol frol added the enhancement New feature or request label Dec 12, 2023
@frol
Copy link
Collaborator Author

frol commented Dec 13, 2023

Resolved with #145.

I have just tested it with:

near contract view-storage poolv1.near all as-json network-config mainnet now

@frol frol closed this as completed Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants