From 1ad22ae05d056bcaf7042196b816d94352e311f2 Mon Sep 17 00:00:00 2001 From: Miki Rozloznik Date: Mon, 3 Feb 2025 11:48:21 +0100 Subject: [PATCH] Update GitHub actions to use upload/download-artifact@v4 --- .github/workflows/build_linux.yml | 12 +++++------- .github/workflows/build_linux_cpp.yml | 8 +++----- .github/workflows/build_linux_doc.yml | 2 +- .github/workflows/build_linux_java.yml | 5 ++--- .github/workflows/build_linux_python.yml | 8 +++----- .github/workflows/build_linux_xml.yml | 2 +- .github/workflows/build_linux_zserio.yml | 3 +-- .github/workflows/build_windows.yml | 12 +++++------- .github/workflows/build_windows_cpp.yml | 8 +++----- .github/workflows/build_windows_doc.yml | 2 +- .github/workflows/build_windows_java.yml | 5 ++--- .github/workflows/build_windows_python.yml | 8 +++----- .github/workflows/build_windows_xml.yml | 2 +- .github/workflows/build_windows_zserio.yml | 3 +-- .github/workflows/sonar_cloud_trigger.yml | 3 +-- 15 files changed, 33 insertions(+), 50 deletions(-) diff --git a/.github/workflows/build_linux.yml b/.github/workflows/build_linux.yml index 6aaf7a947..2d3153e8e 100644 --- a/.github/workflows/build_linux.yml +++ b/.github/workflows/build_linux.yml @@ -31,24 +31,23 @@ jobs: needs: [cpp, java, python, doc, xml] runs-on: "ubuntu-22.04" steps: - # update when https://github.com/actions/download-artifact/issues/315 is fixed - name: "Download Zserio compiler artifacts" - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 with: name: zserio-bin-java8 path: zserio-bin-java8 - name: "Download Java runtime release artifacts" - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 with: name: zserio-runtime-java8 path: zserio-runtime-java8 - name: "Download C++ runtime release artifacts" - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 with: name: zserio-runtime-cpp path: zserio-runtime-cpp - name: "Download Python runtime release artifacts" - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 with: name: zserio-runtime-python path: zserio-runtime-python @@ -86,8 +85,7 @@ jobs: zip -rq ${RELEASE_DIR}/zserio-${ZSERIO_VERSION}-runtime-libs.zip "runtime_libs" - name: "Archive release artifacts" - # update when https://github.com/actions/upload-artifact/issues/543 is fixed - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: linux-release-${{env.ZSERIO_VERSION}} path: release-${{env.ZSERIO_VERSION}} diff --git a/.github/workflows/build_linux_cpp.yml b/.github/workflows/build_linux_cpp.yml index 648d81364..6033062a6 100644 --- a/.github/workflows/build_linux_cpp.yml +++ b/.github/workflows/build_linux_cpp.yml @@ -117,7 +117,7 @@ jobs: submodules: recursive - name: Download Zserio release artifact - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 with: name: zserio-bin-java8 @@ -169,8 +169,7 @@ jobs: scripts/benchmark.sh cpp-${PACKAGE} --num-iterations 1 - name: Upload Zserio C++ runtime artifacts - # update when https://github.com/actions/upload-artifact/issues/543 is fixed - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 # we need to collect this artifact from a build which has both clang coverage and clang-tidy reports if: ${{ matrix.platform == '64' && matrix.clang-version == '14' && matrix.cxx-standard == '11' && matrix.build-type == 'Debug' }} @@ -179,8 +178,7 @@ jobs: path: release-*/*runtime-libs* - name: Upload Zserio C++ build artifacts - # update when https://github.com/actions/upload-artifact/issues/543 is fixed - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: "\ zserio-build-${{matrix.os}}-${{matrix.platform}}-\ diff --git a/.github/workflows/build_linux_doc.yml b/.github/workflows/build_linux_doc.yml index 4d17048d7..e116f7c4b 100644 --- a/.github/workflows/build_linux_doc.yml +++ b/.github/workflows/build_linux_doc.yml @@ -45,7 +45,7 @@ jobs: submodules: recursive - name: Download Zserio release artifact - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 with: name: zserio-bin-java8 diff --git a/.github/workflows/build_linux_java.yml b/.github/workflows/build_linux_java.yml index e1f7bcb5d..bcbbadad8 100644 --- a/.github/workflows/build_linux_java.yml +++ b/.github/workflows/build_linux_java.yml @@ -50,7 +50,7 @@ jobs: submodules: recursive - name: Download Zserio release artifact - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 with: name: zserio-bin-java8 @@ -98,8 +98,7 @@ jobs: scripts/benchmark.sh java --num-iterations 1 - name: Upload Zserio Java runtime artifacts - # update when https://github.com/actions/upload-artifact/issues/543 is fixed - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: "zserio-runtime-java${{matrix.java-version}}" path: release-*/*runtime-libs* diff --git a/.github/workflows/build_linux_python.yml b/.github/workflows/build_linux_python.yml index 1571bbe5d..22761ebc2 100644 --- a/.github/workflows/build_linux_python.yml +++ b/.github/workflows/build_linux_python.yml @@ -53,7 +53,7 @@ jobs: submodules: recursive - name: Download Zserio release artifact - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 with: name: zserio-bin-java8 @@ -105,8 +105,7 @@ jobs: scripts/benchmark.sh python python-cpp --num-iterations 1 - name: Upload Zserio Python runtime artifacts - # update when https://github.com/actions/upload-artifact/issues/543 is fixed - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 # we want this artifact only once since it contains only sources if: ${{ matrix.python-version == '3.8' }} with: @@ -114,8 +113,7 @@ jobs: path: release-*/*runtime-libs* - name: Upload Zserio Python build artifacts - # update when https://github.com/actions/upload-artifact/issues/543 is fixed - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: "zserio-build-${{matrix.os}}-python${{matrix.python-version}}" path: | diff --git a/.github/workflows/build_linux_xml.yml b/.github/workflows/build_linux_xml.yml index 364716bec..623596e4d 100644 --- a/.github/workflows/build_linux_xml.yml +++ b/.github/workflows/build_linux_xml.yml @@ -38,7 +38,7 @@ jobs: submodules: recursive - name: Download Zserio release artifact - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 with: name: zserio-bin-java8 diff --git a/.github/workflows/build_linux_zserio.yml b/.github/workflows/build_linux_zserio.yml index ea7cc2d5a..dbe1016e7 100644 --- a/.github/workflows/build_linux_zserio.yml +++ b/.github/workflows/build_linux_zserio.yml @@ -90,8 +90,7 @@ jobs: scripts/test.sh core - name: Archive Zserio compiler artifacts - # update when https://github.com/actions/upload-artifact/issues/543 is fixed - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: "zserio-bin-java${{matrix.java-version}}" path: release-* diff --git a/.github/workflows/build_windows.yml b/.github/workflows/build_windows.yml index 988569875..2666983f2 100644 --- a/.github/workflows/build_windows.yml +++ b/.github/workflows/build_windows.yml @@ -36,24 +36,23 @@ jobs: run: | choco install zip - # update when https://github.com/actions/download-artifact/issues/315 is fixed - name: "Download Zserio release artifacts" - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 with: name: zserio-bin-java8 path: zserio-bin-java8 - name: "Download Java runtime release artifacts" - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 with: name: zserio-runtime-java8 path: zserio-runtime-java8 - name: "Download C++ runtime release artifacts" - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 with: name: zserio-runtime-cpp path: zserio-runtime-cpp - name: "Download Python runtime release artifacts" - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 with: name: zserio-runtime-python path: zserio-runtime-python @@ -93,8 +92,7 @@ jobs: zip -rq ${RELEASE_DIR}/zserio-${ZSERIO_VERSION}-runtime-libs.zip "runtime_libs" - name: "Archive release artifacts" - # update when https://github.com/actions/upload-artifact/issues/543 is fixed - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: windows-release-${{env.ZSERIO_VERSION}} path: release-${{env.ZSERIO_VERSION}} diff --git a/.github/workflows/build_windows_cpp.yml b/.github/workflows/build_windows_cpp.yml index f81e7d008..75456c5b5 100644 --- a/.github/workflows/build_windows_cpp.yml +++ b/.github/workflows/build_windows_cpp.yml @@ -98,7 +98,7 @@ jobs: submodules: recursive - name: Download Zserio release artifact - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 with: name: zserio-bin-java8 @@ -159,8 +159,7 @@ jobs: scripts/benchmark.sh cpp-${PACKAGE} --num-iterations 1 - name: Archive Zserio C++ runtime artifacts - # update when https://github.com/actions/upload-artifact/issues/543 is fixed - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 # we want this artifact only once since it contains only sources if: ${{ matrix.msvc-toolset == 'v141' && matrix.cxx-standard && matrix.build-type == 'Release' }} with: @@ -168,8 +167,7 @@ jobs: path: release-*/*runtime-libs* - name: Archive Zseiro C++ build artifacts - # update when https://github.com/actions/upload-artifact/issues/543 is fixed - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: "\ zserio-build-${{matrix.os}}-\ diff --git a/.github/workflows/build_windows_doc.yml b/.github/workflows/build_windows_doc.yml index 39d613296..637737fd2 100644 --- a/.github/workflows/build_windows_doc.yml +++ b/.github/workflows/build_windows_doc.yml @@ -54,7 +54,7 @@ jobs: submodules: recursive - name: Download Zserio release artifact - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 with: name: zserio-bin-java8 diff --git a/.github/workflows/build_windows_java.yml b/.github/workflows/build_windows_java.yml index ab04b5d5d..b9a6cc74b 100644 --- a/.github/workflows/build_windows_java.yml +++ b/.github/workflows/build_windows_java.yml @@ -60,7 +60,7 @@ jobs: submodules: recursive - name: Download Zserio release artifact - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 with: name: zserio-bin-java8 @@ -116,8 +116,7 @@ jobs: scripts/benchmark.sh java --num-iterations 1 - name: Archive Zserio Java runtime artifacts - # update when https://github.com/actions/upload-artifact/issues/543 is fixed - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: "zserio-runtime-java${{matrix.java-version}}" path: release-*/*runtime-libs* diff --git a/.github/workflows/build_windows_python.yml b/.github/workflows/build_windows_python.yml index de29e617f..82c16c4d4 100644 --- a/.github/workflows/build_windows_python.yml +++ b/.github/workflows/build_windows_python.yml @@ -65,7 +65,7 @@ jobs: submodules: recursive - name: Download Zserio release artifact - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 with: name: zserio-bin-java8 @@ -126,8 +126,7 @@ jobs: scripts/benchmark.sh python python-cpp --num-iterations 1 - name: Archive Zserio Python runtime artifacts - # update when https://github.com/actions/upload-artifact/issues/543 is fixed - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 # we want this artifact only once since it contains only sources if: ${{ matrix.python-version == '3.8' }} with: @@ -135,8 +134,7 @@ jobs: path: release-*/*runtime-libs* - name: Archive Zserio build artifacts - # update when https://github.com/actions/upload-artifact/issues/543 is fixed - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: "zserio-build-${{matrix.os}}-python${{matrix.python-version}}" path: | diff --git a/.github/workflows/build_windows_xml.yml b/.github/workflows/build_windows_xml.yml index 1a4395cca..15061af64 100644 --- a/.github/workflows/build_windows_xml.yml +++ b/.github/workflows/build_windows_xml.yml @@ -48,7 +48,7 @@ jobs: submodules: recursive - name: Download Zserio release artifact - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 with: name: zserio-bin-java8 diff --git a/.github/workflows/build_windows_zserio.yml b/.github/workflows/build_windows_zserio.yml index adbba0110..87ce64245 100644 --- a/.github/workflows/build_windows_zserio.yml +++ b/.github/workflows/build_windows_zserio.yml @@ -109,8 +109,7 @@ jobs: scripts/test.sh core - name: Archive Zserio compiler artifacts - # update when https://github.com/actions/upload-artifact/issues/543 is fixed - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: "zserio-bin-java${{matrix.java-version}}" path: release-* diff --git a/.github/workflows/sonar_cloud_trigger.yml b/.github/workflows/sonar_cloud_trigger.yml index 657045da0..a5a4c88c2 100644 --- a/.github/workflows/sonar_cloud_trigger.yml +++ b/.github/workflows/sonar_cloud_trigger.yml @@ -20,8 +20,7 @@ jobs: - name: Archive pull request number if: github.event_name == 'pull_request' - # update when https://github.com/actions/upload-artifact/issues/543 is fixed - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: pull_request_number path: pull_request_number.txt