Skip to content

Commit

Permalink
Update GitHub actions to use upload/download-artifact@v4
Browse files Browse the repository at this point in the history
  • Loading branch information
mikir committed Feb 3, 2025
1 parent d91872a commit 1ad22ae
Show file tree
Hide file tree
Showing 15 changed files with 33 additions and 50 deletions.
12 changes: 5 additions & 7 deletions .github/workflows/build_linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,24 +31,23 @@ jobs:
needs: [cpp, java, python, doc, xml]
runs-on: "ubuntu-22.04"
steps:
# update when https://github.com/actions/download-artifact/issues/315 is fixed
- name: "Download Zserio compiler artifacts"
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: zserio-bin-java8
path: zserio-bin-java8
- name: "Download Java runtime release artifacts"
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: zserio-runtime-java8
path: zserio-runtime-java8
- name: "Download C++ runtime release artifacts"
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: zserio-runtime-cpp
path: zserio-runtime-cpp
- name: "Download Python runtime release artifacts"
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: zserio-runtime-python
path: zserio-runtime-python
Expand Down Expand Up @@ -86,8 +85,7 @@ jobs:
zip -rq ${RELEASE_DIR}/zserio-${ZSERIO_VERSION}-runtime-libs.zip "runtime_libs"
- name: "Archive release artifacts"
# update when https://github.com/actions/upload-artifact/issues/543 is fixed
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: linux-release-${{env.ZSERIO_VERSION}}
path: release-${{env.ZSERIO_VERSION}}
8 changes: 3 additions & 5 deletions .github/workflows/build_linux_cpp.yml
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ jobs:
submodules: recursive

- name: Download Zserio release artifact
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: zserio-bin-java8

Expand Down Expand Up @@ -169,8 +169,7 @@ jobs:
scripts/benchmark.sh cpp-${PACKAGE} --num-iterations 1
- name: Upload Zserio C++ runtime artifacts
# update when https://github.com/actions/upload-artifact/issues/543 is fixed
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
# we need to collect this artifact from a build which has both clang coverage and clang-tidy reports
if: ${{ matrix.platform == '64' && matrix.clang-version == '14' && matrix.cxx-standard == '11' &&
matrix.build-type == 'Debug' }}
Expand All @@ -179,8 +178,7 @@ jobs:
path: release-*/*runtime-libs*

- name: Upload Zserio C++ build artifacts
# update when https://github.com/actions/upload-artifact/issues/543 is fixed
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: "\
zserio-build-${{matrix.os}}-${{matrix.platform}}-\
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build_linux_doc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:
submodules: recursive

- name: Download Zserio release artifact
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: zserio-bin-java8

Expand Down
5 changes: 2 additions & 3 deletions .github/workflows/build_linux_java.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ jobs:
submodules: recursive

- name: Download Zserio release artifact
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: zserio-bin-java8

Expand Down Expand Up @@ -98,8 +98,7 @@ jobs:
scripts/benchmark.sh java --num-iterations 1
- name: Upload Zserio Java runtime artifacts
# update when https://github.com/actions/upload-artifact/issues/543 is fixed
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: "zserio-runtime-java${{matrix.java-version}}"
path: release-*/*runtime-libs*
8 changes: 3 additions & 5 deletions .github/workflows/build_linux_python.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ jobs:
submodules: recursive

- name: Download Zserio release artifact
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: zserio-bin-java8

Expand Down Expand Up @@ -105,17 +105,15 @@ jobs:
scripts/benchmark.sh python python-cpp --num-iterations 1
- name: Upload Zserio Python runtime artifacts
# update when https://github.com/actions/upload-artifact/issues/543 is fixed
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
# we want this artifact only once since it contains only sources
if: ${{ matrix.python-version == '3.8' }}
with:
name: "zserio-runtime-python"
path: release-*/*runtime-libs*

- name: Upload Zserio Python build artifacts
# update when https://github.com/actions/upload-artifact/issues/543 is fixed
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: "zserio-build-${{matrix.os}}-python${{matrix.python-version}}"
path: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build_linux_xml.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
submodules: recursive

- name: Download Zserio release artifact
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: zserio-bin-java8

Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/build_linux_zserio.yml
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,7 @@ jobs:
scripts/test.sh core
- name: Archive Zserio compiler artifacts
# update when https://github.com/actions/upload-artifact/issues/543 is fixed
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: "zserio-bin-java${{matrix.java-version}}"
path: release-*
12 changes: 5 additions & 7 deletions .github/workflows/build_windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,24 +36,23 @@ jobs:
run: |
choco install zip
# update when https://github.com/actions/download-artifact/issues/315 is fixed
- name: "Download Zserio release artifacts"
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: zserio-bin-java8
path: zserio-bin-java8
- name: "Download Java runtime release artifacts"
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: zserio-runtime-java8
path: zserio-runtime-java8
- name: "Download C++ runtime release artifacts"
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: zserio-runtime-cpp
path: zserio-runtime-cpp
- name: "Download Python runtime release artifacts"
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: zserio-runtime-python
path: zserio-runtime-python
Expand Down Expand Up @@ -93,8 +92,7 @@ jobs:
zip -rq ${RELEASE_DIR}/zserio-${ZSERIO_VERSION}-runtime-libs.zip "runtime_libs"
- name: "Archive release artifacts"
# update when https://github.com/actions/upload-artifact/issues/543 is fixed
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: windows-release-${{env.ZSERIO_VERSION}}
path: release-${{env.ZSERIO_VERSION}}
8 changes: 3 additions & 5 deletions .github/workflows/build_windows_cpp.yml
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ jobs:
submodules: recursive

- name: Download Zserio release artifact
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: zserio-bin-java8

Expand Down Expand Up @@ -159,17 +159,15 @@ jobs:
scripts/benchmark.sh cpp-${PACKAGE} --num-iterations 1
- name: Archive Zserio C++ runtime artifacts
# update when https://github.com/actions/upload-artifact/issues/543 is fixed
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
# we want this artifact only once since it contains only sources
if: ${{ matrix.msvc-toolset == 'v141' && matrix.cxx-standard && matrix.build-type == 'Release' }}
with:
name: "zserio-runtime-cpp"
path: release-*/*runtime-libs*

- name: Archive Zseiro C++ build artifacts
# update when https://github.com/actions/upload-artifact/issues/543 is fixed
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: "\
zserio-build-${{matrix.os}}-\
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build_windows_doc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ jobs:
submodules: recursive

- name: Download Zserio release artifact
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: zserio-bin-java8

Expand Down
5 changes: 2 additions & 3 deletions .github/workflows/build_windows_java.yml
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ jobs:
submodules: recursive

- name: Download Zserio release artifact
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: zserio-bin-java8

Expand Down Expand Up @@ -116,8 +116,7 @@ jobs:
scripts/benchmark.sh java --num-iterations 1
- name: Archive Zserio Java runtime artifacts
# update when https://github.com/actions/upload-artifact/issues/543 is fixed
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: "zserio-runtime-java${{matrix.java-version}}"
path: release-*/*runtime-libs*
8 changes: 3 additions & 5 deletions .github/workflows/build_windows_python.yml
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ jobs:
submodules: recursive

- name: Download Zserio release artifact
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: zserio-bin-java8

Expand Down Expand Up @@ -126,17 +126,15 @@ jobs:
scripts/benchmark.sh python python-cpp --num-iterations 1
- name: Archive Zserio Python runtime artifacts
# update when https://github.com/actions/upload-artifact/issues/543 is fixed
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
# we want this artifact only once since it contains only sources
if: ${{ matrix.python-version == '3.8' }}
with:
name: "zserio-runtime-python"
path: release-*/*runtime-libs*

- name: Archive Zserio build artifacts
# update when https://github.com/actions/upload-artifact/issues/543 is fixed
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: "zserio-build-${{matrix.os}}-python${{matrix.python-version}}"
path: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build_windows_xml.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ jobs:
submodules: recursive

- name: Download Zserio release artifact
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: zserio-bin-java8

Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/build_windows_zserio.yml
Original file line number Diff line number Diff line change
Expand Up @@ -109,8 +109,7 @@ jobs:
scripts/test.sh core
- name: Archive Zserio compiler artifacts
# update when https://github.com/actions/upload-artifact/issues/543 is fixed
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: "zserio-bin-java${{matrix.java-version}}"
path: release-*
3 changes: 1 addition & 2 deletions .github/workflows/sonar_cloud_trigger.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,7 @@ jobs:

- name: Archive pull request number
if: github.event_name == 'pull_request'
# update when https://github.com/actions/upload-artifact/issues/543 is fixed
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: pull_request_number
path: pull_request_number.txt

0 comments on commit 1ad22ae

Please sign in to comment.