New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

styles: Fix non-working geometry-name based styles. #180

Merged

Waguramu merged 1 commit into fix-featureid-key-hover from fix-geometry-name-style-filter

Jan 22, 2025

+18 −6

Contributor

MisterGC commented Jan 21, 2025

This PR fixes two problems:

Missing availability of the geometry name when using SelfContainedGeometries caused geometry-name based filtering failing in general
Allow the user to express that a rule should only apply to features that have no name without removing special cases to avoid unnecessary reg-ex evaluation.


          styles: Fix non-working geometry-name based styles (cause of lacking …

49f52e4

…geometry name for self-contained geos).

MisterGC requested a review from Waguramu

January 21, 2025 10:22

josephbirkner self-requested a review

January 22, 2025 13:57

Waguramu approved these changes

View reviewed changes

Waguramu merged commit 7590297 into fix-featureid-key-hover

2 checks passed

Waguramu deleted the fix-geometry-name-style-filter branch

January 22, 2025 14:37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet