Fix relation target for visualization

ndsev · Jan 24, 2025 · 847f363 · 847f363
1 parent ac31970
commit 847f363
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/libs/core/src/rule.cpp b/libs/core/src/rule.cpp
@@ -263,7 +263,7 @@ void FeatureStyleRule::parse(const YAML::Node& yaml)
         attributeType_ = yaml["attribute-type"].as<std::string>();
     }
     if (yaml["attribute-filter"].IsDefined()) {
-        // Parse an attribute based on it's field value, e.g. `speedLimitKmh > 100`
+        // Parse an attribute based on its field value, e.g. `speedLimitKmh > 100`
         attributeFilter_ = yaml["attribute-filter"].as<std::string>();
     }
     if (yaml["attribute-layer-type"].IsDefined()) {

diff --git a/libs/core/src/visualization.cpp b/libs/core/src/visualization.cpp
@@ -961,7 +961,7 @@ void RecursiveRelationVisualizationState::render(
         return result;
     };
     auto sourceGeoms = convertMultiValidityWithFallback(r.relation_->sourceValidityOrNull(), r.sourceFeature_);
-    auto targetGeoms = convertMultiValidityWithFallback(r.relation_->sourceValidityOrNull(), r.sourceFeature_);;
+    auto targetGeoms = convertMultiValidityWithFallback(r.relation_->targetValidityOrNull(), r.targetFeature_);;
 
     // Get offset base vector.
     auto offsetBase = localWgs84UnitCoordinateSystem(sourceGeoms[0]);
@@ -984,22 +984,24 @@ void RecursiveRelationVisualizationState::render(
             visu_.addLine(p1hi, p2hi, UnselectableId, rule_, boundEvalFun, offset);
         }
         if (rule_.relationLineEndMarkerStyle()) {
-            if (visualizedFeatures_.emplace(sourceId + "-endmarker").second)
+            if (visualizedFeatures_.emplace(sourceId + "-endmarker").second) {
                 visu_.addLine(
                     p1lo,
                     p1hi,
                     UnselectableId,
                     *rule_.relationLineEndMarkerStyle(),
                     boundEvalFun,
                     offsetBase * rule_.relationLineEndMarkerStyle()->offset());
-            if (visualizedFeatures_.emplace(targetId + "-endmarker").second)
+            }
+            if (visualizedFeatures_.emplace(targetId + "-endmarker").second) {
                 visu_.addLine(
                     p2lo,
                     p2hi,
                     UnselectableId,
                     *rule_.relationLineEndMarkerStyle(),
                     boundEvalFun,
                     offsetBase * rule_.relationLineEndMarkerStyle()->offset());
+            }
         }
     }