Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly retrieve commit metadata for empty changes #37

Open
jnareb opened this issue Oct 30, 2024 · 1 comment
Open

Correctly retrieve commit metadata for empty changes #37

jnareb opened this issue Oct 30, 2024 · 1 comment
Assignees
@jnareb
Labels
bug Something isn't working workaround Not a proper bugfix, but makes things work

Comments

@jnareb
Copy link
Member

jnareb commented Oct 30, 2024

Currently for a commit with no changes from the first parent ChangeSet.__init__ does not retrieve correctly the commit metadata, because it does not find where diff begins - as there isn't one.

Additionally, for empty changes, ensure that 'diff_metadata' and 'changes' key exists, and lead to empty mapping ({}).
@jnareb jnareb added the bug Something isn't working label Oct 30, 2024
@jnareb jnareb self-assigned this Oct 30, 2024
@jnareb
Copy link
Member Author

jnareb commented Nov 7, 2024

Workaround added in 8aee93e and cdba28c (so that diff-gather-stats timeline no longer crashes on such changes).

@jnareb jnareb added the workaround Not a proper bugfix, but makes things work label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jnareb jnareb

Labels
bug Something isn't working workaround Not a proper bugfix, but makes things work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jnareb