Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby v3.0 support #275

Closed
alexskr opened this issue Dec 15, 2022 · 9 comments
Closed

Ruby v3.0 support #275

alexskr opened this issue Dec 15, 2022 · 9 comments
Assignees

Comments

@alexskr
Copy link
Member

alexskr commented Dec 15, 2022

BP/Ontoportal is currently working with ruby v2.7 which is in its maintenance phase and will be EOL soon.
We should start adopting ruby v3.0

So far only ontologies_api_ruby_client project is running unit tests against ruby v3.0

@alexskr alexskr self-assigned this Dec 15, 2022
@jvendetti
Copy link
Member

BioPortal Rails application is on Ruby 3 as of mid September

See this release: https://github.com/ncbo/bioportal_web_ui/releases/tag/v6.13.0

@jvendetti
Copy link
Member

Currently there are three stable Ruby releases available for download (3.1.4, 3.2.2, and 3.3.0). What version does everyone think we should target for the REST API?

@alexskr
Copy link
Member Author

alexskr commented Jan 17, 2024

Currently ontologies_api doesn't work with ruby 3.0+ Throttling unit tests do not pass. We should move to latest version of ruby that API can run on.

@jvendetti
Copy link
Member

I'm aware that it doesn't work with Ruby 3.0+. I asked about this because I'm interested to know what version we should be targeting when we start working on fixing the code to be compatible.

@syphax-bouazzouni
Copy link

syphax-bouazzouni commented Jan 17, 2024

Everyone seems to say that 3.3.0 is a game-changer in terms of performance
image

@alexskr
Copy link
Member Author

alexskr commented Jan 17, 2024

It would be great to use the same ruby version for both API and UI.

@syphax-bouazzouni
Copy link

image

@alexskr
Copy link
Member Author

alexskr commented Sep 24, 2024

related PR:
ncbo/ontologies_api#159
ncbo/ontologies_linked_data#214
ncbo/ncbo_annotator#34

@alexskr
Copy link
Member Author

alexskr commented Oct 4, 2024

done

@alexskr alexskr closed this as completed Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants