README.md

@@ -2,16 +2,17 @@
 A simple API wrapper for the netcup DNS API
 
 ```python
-import nc_dnsapi
+from nc_dnsapi import Client, DNSRecord
 
 customer = 123456
 api_key = "your-personal-api-key"
 api_password = "your-private-api-password"
 
-with nc_dnsapi.Client(customer, api_key, api_password) as api:
+with Client(customer, api_key, api_password) as api:
     # fetch records
     records = api.dns_records("example.com")
-    print(records)
+    for record in records:
+	print(record)
 
     # fetch zone details
     zone = api.dns_zone("example.com")

nc_dnsapi/__init__.py

@@ -22,7 +22,7 @@ def __eq__(self, other):
 
 
 class DNSRecord(object):
-    __valid_types = ['A', 'AAAA', 'MX', 'CNAME', 'CAA', 'SRV', 'TXT', 'TLSA', 'NS', 'DS']
+    __valid_types = ['A', 'AAAA', 'MX', 'CNAME', 'CAA', 'SRV', 'TXT', 'TLSA', 'NS', 'DS', 'OPENPGPKEY', 'SMIMEA', 'SSHFP']
 
     def __init__(self, hostname, type, destination, **kwargs):
         self.hostname = hostname
@@ -37,7 +37,13 @@ def __init__(self, hostname, type, destination, **kwargs):
             raise TypeError("Invalid record type: {}".format(self.type))
 
     def __str__(self):
-        return str(self.__dict__)
+        return '{}({})'.format(self.__class__.__name__, ', '.join(
+            '{}={!r}'.format(k, v)
+            for k, v in self.__dict__.items()
+            if v is not None
+        ))
+
+    __repr__ = __str__
 
     def __eq__(self, other):
         if not isinstance(other, DNSRecord):
@@ -48,7 +54,7 @@ def __eq__(self, other):
         if self.type == 'MX' and other.type == self.type and self.priority:
             result = result and int(self.priority) == int(other.priority)
 
-        if self.id:
+        if self.id and other.id:
             result = result and self.id == other.id
 
         return result
@@ -85,10 +91,18 @@ def request(self, action, **kwargs):
 
             if data['status'] == 'success':
                 return data
+            elif data['statuscode'] == 5029:
+                # empty dns zone
+                return []
             else:
-                raise Exception("{} ({})".format(data['longmessage'], data['statuscode']))
+                exception_message = f"{data['longmessage']} ({data['statuscode']})"
+                if data['statuscode'] == 4013 and action == "login":
+                    exception_message += ". This error occured during login and is usually caused" \
+                        " by wrong API credentials. Please check the provided values."
+
+                raise Exception(exception_message)
         else:
-            raise Exception("{} ({})".format(response.reason, response.status_code))
+            raise Exception("f{response.reason} ({response.status_code})")
 
     def logout(self):
         self.request("logout")
@@ -116,6 +130,9 @@ def update_dns_records(self, domain, records):
             "dnsrecordset": {"dnsrecords": [record.__dict__ for record in records]}
         })
 
+        if 'responsedata' not in data:
+            return []
+
         return [DNSRecord(**r) for r in data['responsedata']['dnsrecords']]
 
     def dns_record_exists(self, domain, record):
@@ -131,7 +148,7 @@ def dns_record(self, domain, record):
         return None
 
     def delete_dns_record(self, domain, record, ignore_unknown=True):
-        if not record.id:
+        if not record or not record.id:
             raise ValueError("Missing id of record to update")
 
         record.deleterecord = True
@@ -152,6 +169,10 @@ def delete_dns_records(self, domain, records):
 
     def dns_records(self, domain):
         data = self.request("infoDnsRecords", params={"domainname": domain})
+
+        if 'responsedata' not in data:
+            return []
+
         return [DNSRecord(**r) for r in data['responsedata']['dnsrecords']]
 
     def update_dns_zone(self, domain, zone):

setup.py

@@ -7,7 +7,7 @@
 
 setuptools.setup(
     name='nc_dnsapi',
-    version='0.1.3',
+    version='0.1.5',
     description='API wrapper for the netcup DNS api',
     long_description=long_description,
     long_description_content_type="text/markdown",