Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutofacSerilogIntegration.dll has the wrong file version #47

Open
bnicholesdell opened this issue Jul 14, 2023 · 1 comment
Open

AutofacSerilogIntegration.dll has the wrong file version #47

bnicholesdell opened this issue Jul 14, 2023 · 1 comment

Comments

@bnicholesdell
Copy link

After updating to AutofacSerilogIntegration v5.0.0 and then trying to upgrade a previous installation of our WiX installer built MSI, AutofacSerilogIntegration.dll was the only file which did not upgrade. Looking at the MSI debug log, it said that the reason why the dll did not upgrade was because the file versions were the same. Checking the file details for the v3.0.0 dll, the file version was 1.0.0. Then checking file details for v5.0.0, the file version is still 1.0.0 even though the product version changed to 5.0.0. Since the WiX installer is looking at the file version, it believes that the versions are the same and therefore won't upgrade the dll.

The file version for the autofacSerilogIntegration.dll should be incrementing with each new version even if the file version does not necessarily match the product version.

@nblumhardt
Copy link
Owner

Thanks for the note, I've hit this kind of thing before 👍

Are you interested in sending a PR that synchronizes the file version with the package version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants