Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no.nav.security.jwt.dont-propagate-bearertoken has reverse meaning #591

Open
espenwaaga opened this issue Sep 2, 2022 · 0 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@espenwaaga
Copy link
Contributor

espenwaaga commented Sep 2, 2022

Problem

BearerTokenClientHttpRequestInterceptor is activated and pulled in as a Bean if either

no.nav.security.jwt.dont-propagate-bearertoken is not set or
no.nav.security.jwt.dont-propagate-bearertoken=true

By setting this value to either nothing or to 'true' one would assume that we "don't propagate bearer token", but that is not the case.

Solution

Fikse ConditonalOnProperty or rename the 'no.nav.security.jwt.dont-propagate-bearertoken' variable to something better like f.eks. 'no.nav.security.jwt.propagate-bearertoken' with default to false.

@espenwaaga espenwaaga added the bug Something isn't working label Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants