-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doesn't auto choose XDR when making a cross-domain request #94
Comments
Thanks for reporting. I had that issue too. Over a year ago, when I was not involved with this project yet. It's a wontfix kind of issue. Detecting if the request is cross domain is also not as easy as we'd want to. So it'd be a big chunk of code added for eberyone while only very few users have any doubts if they are crossing domain boundaries or not on a particular request. Having said all that, I'm open to pull requests with a small and elegant solution I couldn't come up with ;) |
Do you think something like https://github.com/videojs/video.js/blob/stable/src/js/xhr.js#L80-L84 is sufficient or are there some more usecase you can think off that won't be covered? |
There's a better implementation than what I linked above in videojs/video.js#2633 |
That's still a lot of code for a library of the size of xhr anyway. We could distribute a separate library with that feature (assuming it doesn't exist already) it's like with the qs package. We got requests to include that too, but it's better off as an optional thing you can add. |
What about making it in an |
Yes, |
Should this be closed? |
I'm keeping it open because people don't search closed issues and this is a wontfix. |
As a user of XHR, I would expect it to realize when the request will require CORS and choose to use XDR. This is mostly an issue on browsers like IE8 and IE9 where a CORS request requires the usage of XDomainRequest.
The text was updated successfully, but these errors were encountered: