Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "You have been invited as an author" popup #3945

Open
5e-Cleric opened this issue Dec 14, 2024 · 17 comments
Open

Add "You have been invited as an author" popup #3945

5e-Cleric opened this issue Dec 14, 2024 · 17 comments
Labels
feature P1 - high priority Obvious bug or popular features sub-epic Sub-task of an Epic 🚀 V4 Wait for V4

Comments

@5e-Cleric
Copy link
Member

In the editor page, right now, a user can be added as an invited author, which means said user has access to the edit page, but is not an author per-se. To promote themselves to an actual author, the user must save an edit to the file.

Right now, users usually get confused around this feature, because it is barely explained, i propose we add two features:

  1. a explain icon besides the feature in the metadata panel, like so:

image
With an explanation on how the feature works.

  1. A popup in the edit page for when a user enters the edit page of the brew, while being in the invited authors list, to explain the feature to them, giving them clear instructions about how to become or not become an author, as well as to how to remove themselves as author.

  2. Change the deletion button text from deleting brew to remove self from author list if the user is an invited author, or an author but not the only author.

@5e-Cleric 5e-Cleric added feature sub-epic Sub-task of an Epic P1 - high priority Obvious bug or popular features 🚀 V4 Wait for V4 labels Dec 14, 2024
@G-Ambatte
Copy link
Collaborator

G-Ambatte commented Dec 14, 2024

It might also be useful to pop a notification in the Share Page if the current logged in user is an invited author, probably with a link to the Edit Page where they can accept the invitation.

@ericscheid
Copy link
Collaborator

A reminder that one of the design goals of the invited author functionality was that it should not be available to be abused as a channel or vector for abuse or harassment.

Note though that none of the suggestions here do that — but they are getting close. Take this as only a caution regarding any additional messaging options.

@G-Ambatte
Copy link
Collaborator

There was a recent Discord user who reported that they had been invited to co-author a brew, but had no idea how to access it - the original author sent them the Share link, not the Edit link, and currently there is nothing in place to direct an Invited Author to the correct page.

@calculuschild
Copy link
Member

calculuschild commented Dec 15, 2024

How about this: instead of a popup or messaging system, we just add a new section to the user page with author invitations?

Author Invitations
User's Published Brews
User's Unpublished Brews

Kind of like how Google Drive has a "Shared with me" folder?

@ericscheid
Copy link
Collaborator

ericscheid commented Dec 15, 2024 via email

@G-Ambatte
Copy link
Collaborator

100% no.

I think there's a number of steps to put in place first.

  • publish acceptable community content standard (including penalties for failing to meet them)
  • create a reporting system (brews & user)
  • improve/finish the locking system

I should also mention, especially in the light of recent user reports, that I believe we're almost certainly going to have to take these steps anyway, regardless of whether "Invited Brews" ever appears in the User Page.

@5e-Cleric
Copy link
Member Author

Well, i do prefer my original idea instead of the userpage's.

@calculuschild
Copy link
Member

calculuschild commented Dec 15, 2024

I'm seeing multiple related, but different issues here. I think 5e-Cleric intended to address #1 and #2:

  1. Users don't know how to initiate an invite of co-authors (could be solved by better documentation / UI, as proposed by 5e-Cleric)
  2. Users don't know how to transition from invited to a full author (5e-Cleric proposes a notification with instructions upon opening the edit link)
  3. Users don't know how to access an invited brew (either some kind of notification to the invited author, or better instruction for the owning author)
  4. Users don't know how to give their co-authors access (probably solved if #3 is solved)

Its ok if this issue focuses on #1 and #2.

The Userpage suggestion was in response to "discord user didn't know how to access the brew". I apologize that was going off topic into the #3 and #4 issues.

100% no

It would seem that any type of signal to the invited author for #3 and #4 is a vector for harassment. This means the only way forward for those is better instructions on the owner end.

@dbolack-ab
Copy link
Collaborator

I think it would be reasonable if a logged-in user is prompted when they are an invited user on a shareID or editID path.

The prompt should allow them to accept, decline, or sleep the invite. If they accept or decline, the brew should be updated. If they sleep, session data should be stored so that the prompt can query and not pop up for a week.

I don't think we need to provide instructions - just a simple, actionable interface along with a "not right now!" option.

@calculuschild
Copy link
Member

The concern is if anyone happens to know your username and wants to be abusive, they can just set continually invite you to documents you don't want. Spam notifications.

So the preferred approach is to not let users trigger notifications on another user like this at all.

@5e-Cleric
Copy link
Member Author

I think it would be reasonable if a logged-in user is prompted when they are an invited user on a shareID or editID path.

Not logged in users just cannot be invited so ... yes

The prompt should allow them to accept, decline, or sleep the invite. If they accept or decline, the brew should be updated. If they sleep, session data should be stored so that the prompt can query and not pop up for a week.

I don't think we need to provide instructions - just a simple, actionable interface along with a "not right now!" option.

I agree 100%

The concern is if anyone happens to know your username and wants to be abusive, they can just set continually invite you to documents you don't want. Spam notifications.

So the preferred approach is to not let users trigger notifications on another user like this at all.

Abquintic specified to show a popup when the invited author enters the share or edit pages. no spam that way.

@ericscheid
Copy link
Collaborator

The concern is if anyone happens to know your username and wants to be abusive, they can just set continually invite you to documents you don't want. Spam notifications. So the preferred approach is to not let users trigger notifications on another user like this at all.

Abquintic specified to show a popup when the invited author enters the share or edit pages. no spam that way.

Defnitely no notifications outwith the page being invited to.

Nonetheless, a spammer could see that a spammee has declined the invite and invite them again. And again when they next decline. That'll get old fast (this assumes the page in question is one they have reason to visit regularly). If the victim sleeps the invitation then they won't see the notification for a week, and thus the spam onslaught is slowed.

So, a slight thwarting of the attack vector. Further amelioration is possible if the notification is non-modal and non-intrusive. That is, the opposite of a dialog that pops up and demands attention before allowing access. A notification like a strip-line across the top of the page that can be ignored.

strip-line notification

Still, this is a dangerous path to proceed down. The code should include a comment noting the potential for weaponising and this line of thinking. (We don't want a future contributor thinking "this notification isn't easy enough to use, let me «improve» the usability".)

@dbolack-ab
Copy link
Collaborator

The concern is if anyone happens to know your username and wants to be abusive, they can just set continually invite you to documents you don't want. Spam notifications. So the preferred approach is to not let users trigger notifications on another user like this at all.

Abquintic specified to show a popup when the invited author enters the share or edit pages. no spam that way.

Defnitely no notifications outwith the page being invited to.

Then you have a (&)( useless feature.

@ericscheid
Copy link
Collaborator

Defnitely no notifications outwith the page being invited to.

Then you have a (&)( useless feature.

I'm agreeing with Abquintic that a notification can be shown on the share or edit pages, and not be shown elsewhere. Don't show it on random other pages, not shown on their userpage, not shown on the home page .. but do show it on the page in question. How is that useless?

@calculuschild
Copy link
Member

calculuschild commented Jan 17, 2025

I agree its much better if we are talking about notifications on the invited page itself. That wasn't clear to me when I first read it.

@dbolack-ab
Copy link
Collaborator

Defnitely no notifications outwith the page being invited to.

Then you have a (&)( useless feature.

I'm agreeing with Abquintic that a notification can be shown on the share or edit pages, and not be shown elsewhere. Don't show it on random other pages, not shown on their userpage, not shown on the home page .. but do show it on the page in question. How is that useless?

I misread something or tunnel-visioned. I dunno. We are in agreement here.

@5e-Cleric
Copy link
Member Author

Have i been reading too much Schrödinger or are you guys agreeing and disagreeing at the same time? hah

So, i propose, we bring up our dialog component, should be easy enough to use, and it can be non-blocking, like our notifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature P1 - high priority Obvious bug or popular features sub-epic Sub-task of an Epic 🚀 V4 Wait for V4
Projects
None yet
Development

No branches or pull requests

5 participants