-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "You have been invited as an author" popup #3945
Comments
It might also be useful to pop a notification in the Share Page if the current logged in user is an invited author, probably with a link to the Edit Page where they can accept the invitation. |
A reminder that one of the design goals of the invited author functionality was that it should not be available to be abused as a channel or vector for abuse or harassment. Note though that none of the suggestions here do that — but they are getting close. Take this as only a caution regarding any additional messaging options. |
There was a recent Discord user who reported that they had been invited to co-author a brew, but had no idea how to access it - the original author sent them the Share link, not the Edit link, and currently there is nothing in place to direct an Invited Author to the correct page. |
How about this: instead of a popup or messaging system, we just add a new section to the user page with author invitations? Author InvitationsUser's Published BrewsUser's Unpublished BrewsKind of like how Google Drive has a "Shared with me" folder? |
How about this: instead of a popup or messaging system, we just add a new section to the user page with author invitations?
Author Invitations
User's Published Brews
User's Unpublished Brews
100% no. That is a vector for harassment. Imagine being on the receiving end of a hate campaign, with your personal home page overwhelmed with brews with utterly noxious titles and descriptions.
|
I think there's a number of steps to put in place first.
I should also mention, especially in the light of recent user reports, that I believe we're almost certainly going to have to take these steps anyway, regardless of whether "Invited Brews" ever appears in the User Page. |
Well, i do prefer my original idea instead of the userpage's. |
I'm seeing multiple related, but different issues here. I think 5e-Cleric intended to address
Its ok if this issue focuses on The Userpage suggestion was in response to "discord user didn't know how to access the brew". I apologize that was going off topic into the
It would seem that any type of signal to the invited author for |
I think it would be reasonable if a logged-in user is prompted when they are an invited user on a shareID or editID path. The prompt should allow them to accept, decline, or sleep the invite. If they accept or decline, the brew should be updated. If they sleep, session data should be stored so that the prompt can query and not pop up for a week. I don't think we need to provide instructions - just a simple, actionable interface along with a "not right now!" option. |
The concern is if anyone happens to know your username and wants to be abusive, they can just set continually invite you to documents you don't want. Spam notifications. So the preferred approach is to not let users trigger notifications on another user like this at all. |
Not logged in users just cannot be invited so ... yes
I agree 100%
Abquintic specified to show a popup when the invited author enters the share or edit pages. no spam that way. |
Then you have a (&)( useless feature. |
I'm agreeing with Abquintic that a notification can be shown on the share or edit pages, and not be shown elsewhere. Don't show it on random other pages, not shown on their userpage, not shown on the home page .. but do show it on the page in question. How is that useless? |
I agree its much better if we are talking about notifications on the invited page itself. That wasn't clear to me when I first read it. |
I misread something or tunnel-visioned. I dunno. We are in agreement here. |
Have i been reading too much Schrödinger or are you guys agreeing and disagreeing at the same time? hah So, i propose, we bring up our dialog component, should be easy enough to use, and it can be non-blocking, like our notifications. |
In the editor page, right now, a user can be added as an
invited author
, which means said user has access to the edit page, but is not an author per-se. To promote themselves to an actual author, the user must save an edit to the file.Right now, users usually get confused around this feature, because it is barely explained, i propose we add two features:
With an explanation on how the feature works.
A popup in the edit page for when a user enters the edit page of the brew, while being in the invited authors list, to explain the feature to them, giving them clear instructions about how to become or not become an author, as well as to how to remove themselves as author.
Change the deletion button text from deleting brew to
remove self from author list
if the user is an invited author, or an author but not the only author.The text was updated successfully, but these errors were encountered: