Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add Support for Light Themes on Apps When Materia Dark Variants are Enabled #326

Closed
btd1337 opened this issue Dec 9, 2018 · 2 comments

Comments

@btd1337
Copy link

btd1337 commented Dec 9, 2018

Many new apps are coming with switch theme option. In Materia Light it's works fine but in Dark variant this switch doesn't works properly.

Look:

Materia Default Theme

Sequeler App Using Light Variant: Fine (Just white labels isn't good)

captura de tela de 2018-12-09 16-30-05

Sequeler App Using Dark Variant: Fine

captura de tela de 2018-12-09 16-32-27

Materia Dark Variant

Sequeler App Using Light Variant: Fail

captura de tela de 2018-12-09 16-14-22

Sequeler App Using Dark Variant: Fine

captura de tela de 2018-12-09 16-36-59

Could you add this same support on Dark variant theme?

Congratulations on this great work! Thank you in advance!

@nana-4
Copy link
Owner

nana-4 commented Dec 9, 2018

Hi. I think you are talking about elementary/Pantheon apps (as most of other GTK+ apps don't have the light/dark toggle).

In any case, having light theme variant while using dark theme is technically impossible. Not only Materia-dark, but also all GTK+ dark themes can't have the option.

This is why elementaryOS doesn't have a global dark theme and instead its apps have the switch theme option...

@nana-4
Copy link
Owner

nana-4 commented Dec 9, 2018

P.S.

Just white labels isn't good

It should be another bug. And Materia doesn't officially support Pantheon at the moment. (See #69)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants