Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a new UserProfile Section #48

Open
shiv07tiwari opened this issue Mar 6, 2019 · 5 comments
Open

Make a new UserProfile Section #48

shiv07tiwari opened this issue Mar 6, 2019 · 5 comments
Labels
enhancement New feature or request

Comments

@shiv07tiwari
Copy link
Contributor

As we are making an app for photo sharing inspired by Snapchat, we should make a UserProfile Section, where the user can see and change the following -

  • Profile Pic
  • Usename
  • Various Other personal details such as DOB, Gender, etc
  • Password change option can be provided here

Implementing this will allow us to remove the pic from the toolbar, which looks bad and doesnt follow the material design guidelines.
image
Somewhat similar to this, with our fields.

@shiv07tiwari
Copy link
Contributor Author

@agawande @jrandallclark Should I add this ?

@jrandallclark
Copy link
Contributor

For now, users have no way of accessing each other's profiles, so this would not serve a purpose for the time being. This might be something we will look into later.

I'm curious as to why you think the picture in the toolbar looks bad and where in Google's material design guidelines it recommends against having it. Both Snapchat and Twitter include the user's profile picture in their top toolbar.

@jrandallclark jrandallclark added the enhancement New feature or request label Mar 6, 2019
@shiv07tiwari
Copy link
Contributor Author

@jrandallclark Its not for others to view someone else's profile, but for the user itself to change the password, username and profile picture.

I just think its not a good idea to place the pic in toolbar. It doesn't look good in my opinion. I also never saw such design in any of the designing courses, thus thought it isn't as per the conventional way.

@jrandallclark
Copy link
Contributor

Ok. I will look into whether or not we should keep the profile picture in the toolbar, but we will keep it for now.

As for the username and password, the app does not support changing either of those. The user's name is a fundamental part how npChat works. (See #19 & #21) Because the user cannot log in and out, the password is not actually being used right now, so there is no need to change it either.

The user can already change their profile picture in the settings menu, as well.

@shiv07tiwari
Copy link
Contributor Author

@jrandallclark Okay I missed the point that username is associated with the public key. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants