Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Camera Activity Improvements #106

Open
AshwinChandlapur opened this issue Mar 11, 2019 · 3 comments
Open

Camera Activity Improvements #106

AshwinChandlapur opened this issue Mar 11, 2019 · 3 comments

Comments

@AshwinChandlapur
Copy link
Contributor

AshwinChandlapur commented Mar 11, 2019

Hey,
I am going through the code base, here are few things that I noticed. I can work on these and provide fixes for them.

  1. Start Camera: A list of other features including the current ones can be provided.
    We can provide image editing features such as
    a. Crop Image
    b. Pinch to Zoom
    c. Rotate Image

Also, After clicking the image, the back button event listener is not set. The back button should take user back to cameraActivity.(Phone used - OnePlus 3)

  1. The ViewFriends activity relies on drawing TextView for every Friend in the friendList. To improve rendering and performance, RecyclerView can be used.

  2. Toolbar contains avatar picture. In terms of design, it is recommended to have icons of the respective activity that is shown to user.

  3. All Buttons lead to Individual activities, instead we can use Fragments to improve app-design.

  4. Currently, the sign-up activity is commented out. I was wondering if we can use Firebase authentication during on-boarding procedure.

  5. CardView library can be used to improve UI of the app. Also, converting all png images to webp images will help in reducing the apk size.

  6. We can have a method at start-up which checks for NDN Forwarding Daemon app. If the app is not installed, we can have an intent to Playstore. If app is installed continue with regular onboarding.

@jrandallclark and @agawande Few of them might not be relevant to the project from your perspective. But I have just mentioned them. Let me know If I can work on any of these.

@AshwinChandlapur AshwinChandlapur changed the title Camera Activity can be Improved Camera Activity Improvements Mar 11, 2019
@jrandallclark
Copy link
Contributor

jrandallclark commented Mar 12, 2019

All but item 5 would be great addition to npChat. The login/registration method we are using currently is how we need to keep it right now. (#11 (comment))

@AshwinChandlapur
Copy link
Contributor Author

Sure. I will submit PR for each task as soon as I complete. Also, I was wondering If I can use any libraries?

@jrandallclark
Copy link
Contributor

Yes. You can use stable libraries as needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants