Change default values

[infinity0]

Hardware is OnePlus 5T dumpling, running microG lineageOS 16.

The default value for "moved threshold" is 1250m which feels a bit excessive. Fairly often, I've run into situations where my GPS is giving a false location because wifi_backend has collected some bogus data somehow, but won't change it even when the actual hardware GPS is giving the correct location, because the bogus data is within 1250m of the new correct data.

I suppose 1250m perhaps was chosen for the case when you're in a large building where the same wifi network stretches a long distance. But even in this case I'd argue the current behaviour is confusing, since it will pinpoint you at a particular point in the building even if you're somewhere else. Also, I've never needed this functionality - generally buildings block GPS and I have to lean by the windows to get a signal anyway. If I'm sitting in an office, I'd rather lean against my own window and have wifi_backend use the location of my window, rather than the location of the entrance I entered the building through. (And I stress again, I have not actually encountered this situation IRL.)

I am now getting reasonable results when I set "moved threshold" to 50m (down from 1250m) and "moved guard" to 100 samples (down from 500), with the minimum distance remaining at the default value of 25m.

Another thing is the "required accuracy" might be better set as 15m - I've been in a fair number of situations where the GPS signal is not that great, but 15m is achievable.

Generally, since we're continuosly collecting data anyway, there is no reason we should make it "too hard" to move an AP location when we get new data. The only purpose of this feature should be to avoid moving the AP location by tiny amounts every millisecond which might waste power - not to blindly believe that old data is somehow more valid than new data, and block updates.