Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a new release (0.7) #48

Closed
mwild1 opened this issue Aug 23, 2018 · 8 comments
Closed

Make a new release (0.7) #48

mwild1 opened this issue Aug 23, 2018 · 8 comments

Comments

@mwild1
Copy link
Owner

mwild1 commented Aug 23, 2018

Hey folks, I think it's time we made a new release. Anyone feel inclined to take this on? If not, I can do it.

Any objections or blockers that anyone is aware of?

@sparked435
Copy link
Collaborator

I think a proper resolution to #44 would be good, but that's also a nice to have and not a requirement.

I may be able to find some time to do a formal release this weekend.

@JorjBauer
Copy link

If anyone is addressing #44, then pull request #46 could fit in that paradigm (as both are initialization problems).

I'm not sure what pull request #45 is waiting for - it adds a bit of Oracle functionality in production environments, and I'd like to see that in a release.

@kawaii
Copy link

kawaii commented Sep 27, 2018

Just giving this a nudge since the current version in Debian 9 repositories has started to cause us some issues on a production server. Seems that at some point a nasty segfault with PostgreSQL databases was fixed and hasn't yet made it into a release in Debian. Would be nice if this could be resolved soon, thanks. :)

@linuxmaniac
Copy link
Contributor

@kawaii I already upload a newer version 0.6 to Debian but it's only available in buster/sid
https://tracker.debian.org/pkg/lua-dbi

@mwild1
Copy link
Owner Author

mwild1 commented Sep 28, 2018

Given the bug-fixes we already have ready, I have tagged v0.7 in the repository.

If there are some ready PRs, all the more reason for a 0.8 soon :)

@sparked435
Copy link
Collaborator

Whoops. I embedded a version number, that's now incorrect in the tag for v0.7:

luadbi/DBI.lua

Line 85 in 315a2fa

_M._VERSION = '0.7'

No worries though, I actually forgot that was there until the scripts I have for building the release for LuaRocks caught it :)

@sparked435
Copy link
Collaborator

0.7 uploaded to Lua Rocks.

Besides the usual notification email to the Lua-L mailing list, anything else that we need/should do for a release? Or is it time to close this?

@mwild1
Copy link
Owner Author

mwild1 commented Sep 29, 2018

@sparked435 great, thanks!! Sorry, I missed the version number. Maybe we can tag 0.7.1 with just this fix. I recently had quite some issues debugging a problem with another Lua library and found I wasn't running the version it reported as :) (at least there is no 0.6.1 here).

Maybe we could add a release checklist in a RELEASE.md or something...

@mwild1 mwild1 closed this as completed Sep 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants