Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A suggestion #23

Open
vu1Art1st opened this issue Oct 30, 2023 · 2 comments
Open

A suggestion #23

vu1Art1st opened this issue Oct 30, 2023 · 2 comments

Comments

@vu1Art1st
Copy link

In file base_chain.py line 88, I suggest to change the code
base64.b16decode(encoded_base, casefold=False).decode('utf-8', 'replace')
to
base64.b16decode(encoded_base.upper(), casefold=False).decode('utf-8', 'replace')

@berwil-1
Copy link

berwil-1 commented Sep 5, 2024

Just ran into this issue and I agree, but then why not casefold=True? The docs say "For security purposes, the default is False" for casefold. I don't see why there would be any security concern of accepting lower-case input for this project, correct me if I'm wrong.

@vu1Art1st
Copy link
Author

Just ran into this issue and I agree, but then why not casefold=True? The docs say "For security purposes, the default is False" for casefold. I don't see why there would be any security concern of accepting lower-case input for this project, correct me if I'm wrong.

Sry, I didn't view the whole code.This suggestion just try to resolve an error when decoding lower case base32, for this i just add ".upper()"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants