Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for Firefox add-on #8

Open
bdls-jamal opened this issue Oct 23, 2024 · 4 comments · Fixed by #9
Open

Request for Firefox add-on #8

bdls-jamal opened this issue Oct 23, 2024 · 4 comments · Fixed by #9

Comments

@bdls-jamal
Copy link

Looking for ways to use this extension on Firefox or information on how to develop this capacity by modifying the source code.

@mtusnio
Copy link
Owner

mtusnio commented Oct 24, 2024

Hey @bdls-jamal ! I am currently in the process of ironing out a v2 release to support Manifest v3 - I have only a few bugs left to squash that the automated tests are not able to pick up.

I am planning to have a look afterwards if I can adapt things more easily for FF, especially if I could reuse the browser test to verify it works properly. Should have more time in November to give this a look and see how feasible/easy it is :)

@mtusnio
Copy link
Owner

mtusnio commented Oct 24, 2024

If this is to be believed it might be a case of changing all the chrome calls to browser, and modifying the test setup for browser tests to run both Chrome and Firefox tests.

@bdls-jamal
Copy link
Author

Amazing, looking forward to the release!

@mtusnio mtusnio closed this as completed in #9 Nov 8, 2024
@mtusnio
Copy link
Owner

mtusnio commented Nov 11, 2024

Hey @bdls-jamal I have released this so far - https://addons.mozilla.org/en-GB/firefox/addon/chinese-popup-dictionary/ - however I realised that Firefox handles permissions differently, so it appears you need to allow the extension on each site or disable/enable it dynamically to have it work on each refresh. I will have to fix that up, but other than that the basic functionality seems to be working

@mtusnio mtusnio reopened this Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants