Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pacman 6.1.0 references package_source_files function that doesn't exist #51

Open
jeremyd2019 opened this issue May 13, 2024 · 2 comments

Comments

@jeremyd2019
Copy link
Member

jeremyd2019 commented May 13, 2024

elif check_option "debug" "y"; then
msg2 "$(gettext "Copying source files needed for debug symbols...")"
dbgsrcdir="${DBGSRCDIR:-/usr/src/debug}/${pkgbase}"
dbgsrc="$pkgdirbase/$pkgbase/$dbgsrcdir"
mkdir -p "$dbgsrc"
local binary
find . -type f -perm -u+w -print0 2>/dev/null | while IFS= read -rd '' binary ; do
package_source_files "$binary" 2>/dev/null
done
fi

I think this is an oversight in the rebasing that was done in #45. I haven't yet actually seen it cause a problem, but I think it would fail if options are 'debug' '!strip'.

@lazka
Copy link
Member

lazka commented May 13, 2024

oops, thanks

@lazka
Copy link
Member

lazka commented May 14, 2024

I think I'm just going to split the windows strip code into a separate file. Rebasing is always a pain there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants