Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch cleanup ideas #29

Open
lazka opened this issue Mar 2, 2023 · 1 comment
Open

Patch cleanup ideas #29

lazka opened this issue Mar 2, 2023 · 1 comment

Comments

@lazka
Copy link
Member

lazka commented Mar 2, 2023 •
edited
Loading

  1. as pointed out in pacman: Update to 6.0.2 MSYS2-packages#3594 (comment) it's questionable how we call gpg there

  2. 1fbb46d can likely be dropped

  3. c802539 should be moved where other things are exported and I don't think "DXSDK_DIR ACLOCAL_PATH PKG_CONFIG_PATH" is actually needed

  4. 6b51761#diff-ebd20edda3f2f2f4112739efa148c55502c0bc59f9b357c882ee23b2db46983d set -e is missing

  5. I'm wondering if all this is actually needed and calling "file" is enough: 3077636#diff-b39914dda73d12220ebef7e970cd3f7613f04113293e673f7936695a8969bc2aR118-R185 also file is called again in strip for no reason

  6. This seems questionable: 235ea43

and more...
@lazka lazka mentioned this issue Mar 2, 2023
Merged
@lazka
Copy link
Member Author

lazka commented Mar 11, 2023

Aha, I found the likely source of the stripping logic: https://repo.or.cz/cygport/rpm-style.git/blob/HEAD:/lib/src_postinst.cygpart#l933

@lazka lazka mentioned this issue Jan 4, 2024
Open
@lazka lazka mentioned this issue Apr 28, 2024
Merged
lazka added a commit to lazka/msys2-pacman that referenced this issue Apr 28, 2024
@lazka
Revert "makepkg: bash v4 compat"
0780a4c 
This reverts commit 1fbb46d.

We are on bash v5 for a long time now

See msys2#29
@lazka lazka mentioned this issue Apr 28, 2024
Merged
lazka added a commit that referenced this issue Apr 29, 2024
@lazka
Revert "makepkg: bash v4 compat"
47d0b2b 
This reverts commit 1fbb46d.

We are on bash v5 for a long time now

See #29
lazka added a commit to lazka/msys2-pacman that referenced this issue Apr 30, 2024
@lazka
Revert "More debugging info"
9e78ebf 
This reverts commit 235ea43.

See msys2#29
@lazka lazka mentioned this issue Apr 30, 2024
Merged
lazka added a commit that referenced this issue Apr 30, 2024
@lazka
Revert "More debugging info"
2ab815f 
This reverts commit 235ea43.

See #29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lazka