Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated tmp dependency uses deprecated node internals #27

Open
nunico opened this issue Jul 27, 2021 · 0 comments
Open

Outdated tmp dependency uses deprecated node internals #27

nunico opened this issue Jul 27, 2021 · 0 comments

Comments

@nunico
Copy link

nunico commented Jul 27, 2021

Right now, I'm getting a lot of deprecation warnings on cli programs using inquirer which depends on external-editor. This is due to an outdated version of tmp which there's already a PR: #23

Please consider merging the PR since there are people like me working on node projects and have set NODE_PENDING_DEPRECATION=1 where we will see all of those warnings and want the tools we use not to use deprecated and/or internal APIs.

Here is an example using bitwarden-cli:

❯ node --trace-deprecation $(which bw) -- status
(node:25078) [DEP0111] DeprecationWarning: process.binding() is deprecated. Please use public APIs instead.
    at Object.<anonymous> (/usr/local/Cellar/bitwarden-cli/1.17.1/libexec/lib/node_modules/@bitwarden/cli/node_modules/tmp/lib/tmp.js:16:20)
    at Module._compile (internal/modules/cjs/loader.js:1063:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1092:10)
    at Module.load (internal/modules/cjs/loader.js:928:32)
    at Function.Module._load (internal/modules/cjs/loader.js:769:14)
    at Module.require (internal/modules/cjs/loader.js:952:19)
    at require (internal/modules/cjs/helpers.js:88:18)
    at Object.<anonymous> (/usr/local/Cellar/bitwarden-cli/1.17.1/libexec/lib/node_modules/@bitwarden/cli/node_modules/external-editor/main/index.js:13:13)
    at Module._compile (internal/modules/cjs/loader.js:1063:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1092:10)

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant