Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

b4 retrieves random versions of the dependencies added with message-id #42

Open
gstols opened this issue Aug 15, 2024 · 0 comments
Open

Comments

@gstols
Copy link

gstols commented Aug 15, 2024

When I wanted to apply my series with shazam to test it, one of the dependencies ([email protected]) could not apply (I added them using message-id).
As show below in the output, most of the patches come from the v2, but one comes from v3 and another from v1, causing a failure in applying the series.
I use b4 version 0.14.1 on Ubuntu.

$ b4 shazam https://lore.kernel.org/linux-iio/20240815-ad7606_add_iio_backend_support-v1-0-cea3e11b1aa4@baylibre.com/T/#t
Grabbing thread from lore.kernel.org/all/20240815-ad7606_add_iio_backend_support-v1-0-cea3e11b1aa4@baylibre.com/t.mbox.gz
Checking for newer revisions
Grabbing search results from lore.kernel.org
Analyzing 9 messages in the thread
Analyzing 0 code-review messages
Checking attestationn on all messages, may take a moment...
---
  ✓ [PATCH 1/8] dt-bindings: iio: adc: ad7606: Make corrections on spi conditions
  ✓ [PATCH 2/8] dt-bindings: iio: adc: ad7606: Add iio backend bindings
  ✓ [PATCH 3/8] Documentation: iio: Document ad7606 driver
  ✓ [PATCH 4/8] pwm: Export pwm_get_state_hw
  ✓ [PATCH 5/8] platform: add platform_get_device_match_data() helper
  ✓ [PATCH 6/8] iio: adc: ad7606: Add PWM support for conversion trigger
  ✓ [PATCH 7/8] iio: adc: ad7606: Switch to xxx_get_device_match_data
  ✓ [PATCH 8/8] iio:adc:ad7606: Add iio-backend support
  ---
  ✗ No key: ed25519/[email protected]
  ✓ Signed: DKIM/baylibre-com.20230601.gappssmtp.com (From: [email protected])
---
Total patches: 8
---
 Base: using specified base-commit 7cad163c39cb642ed587d3eeb37a5637ee02740f
 Deps: looking for dependencies matching 10 patch-ids
 Deps: Applying prerequisite patch: [PATCH] pwm: Make info in traces about affected pwm more useful
 Deps: Applying prerequisite patch: [PATCH] pwm: Don't export pwm_capture()
 Deps: Applying prerequisite patch: [PATCH v2 6/8] pwm: Add tracing for waveform callbacks
 Deps: Applying prerequisite patch: [PATCH v3 1/8] pwm: Simplify pwm_capture()
 Deps: Applying prerequisite patch: [PATCH v2 7/8] pwm: axi-pwmgen: Implementation of the waveform callbacks
 Deps: Applying prerequisite patch: [PATCH v2 3/8] pwm: New abstraction for PWM waveforms
 Deps: Applying prerequisite patch: [PATCH v2 5/8] pwm: Add support for pwmchip devices for faster and easier userspace access
 Deps: Applying prerequisite patch: [PATCH 6/6] pwm: stm32: Implementation of the waveform callbacks
 Deps: Applying prerequisite patch: [PATCH v2 2/8] pwm: Add more locking
 Deps: Applying prerequisite patch: [PATCH v2 4/8] pwm: Provide new consumer API functions for waveforms
Applying: pwm: Make info in traces about affected pwm more useful
Applying: pwm: Don't export pwm_capture()
Applying: pwm: Add tracing for waveform callbacks
Patch failed at 0003 pwm: Add tracing for waveform callbacks
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
error: patch failed: drivers/pwm/core.c:166
error: drivers/pwm/core.c: patch does not apply
hint: Use 'git am --show-current-patch=diff' to see the failed patch

However, when I apply the dependencies individually with b4 shazam, it takes the V3 for all the patches:

$ b4 shazam [email protected]
Grabbing thread from lore.kernel.org/all/[email protected]/t.mbox.gz
Checking for newer revisions
Grabbing search results from lore.kernel.org
  Added from v3: 9 patches
Analyzing 38 messages in the thread
Looking for additional code-review trailers on lore.kernel.org
Analyzing 17 code-review messages
Will use the latest revision: v3
You can pick other revisions using the -vN flag
Checking attestation on all messages, may take a moment...
---
  ✗ [PATCH v3 1/8] pwm: Simplify pwm_capture()
  ✗ [PATCH v3 2/8] pwm: Add more locking
  ✗ [PATCH v3 3/8] pwm: New abstraction for PWM waveforms
  ✗ [PATCH v3 4/8] pwm: Provide new consumer API functions for waveforms
  ✗ [PATCH v3 5/8] pwm: Add support for pwmchip devices for faster and easier userspace access
  ✗ [PATCH v3 6/8] pwm: Add tracing for waveform callbacks
  ✗ [PATCH v3 7/8] pwm: axi-pwmgen: Implementation of the waveform callbacks
  ✗ [PATCH v3 8/8] pwm: stm32: Implementation of the waveform callbacks
  ---
  ✗ No key: openpgp/[email protected]
  ✗ BADSIG: DKIM/baylibre-com.20230601.gappssmtp.com
---
Total patches: 8
---
 Base: base-commit b9b6bd3dcceed371829a022caeb6b51cb9f67be9 not known, ignoring
Applying: pwm: Simplify pwm_capture()
Applying: pwm: Add more locking
Applying: pwm: New abstraction for PWM waveforms
Applying: pwm: Provide new consumer API functions for waveforms
Applying: pwm: Add support for pwmchip devices for faster and easier userspace access
Applying: pwm: Add tracing for waveform callbacks
Applying: pwm: axi-pwmgen: Implementation of the waveform callbacks
Applying: pwm: stm32: Implementation of the waveform callbacks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant