mrc-4588 Display model fit error details #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmmaLRussell
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
📢 Thoughts on this report? Let us know!. |
M-Kusumgar
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch ensures that any error throws when a model fit starts running is saved to the state and displayed on the Fit tab.
An ErrorInfo component has been added to the tab, and if an error is present any previous fit results are faded, with a message shown in the "Action Required" space.
Steps to generate this error:
- go to Fit app in Wodin
- upload sample data (influenza_data(1).csv), go to options tab and fit tabs
- link "E"
- select "D" and "L" model parameters
- Fit model
- Change tolerance to 7 x 10^ -1
- Fit model
There is another potential error which we should also display, in the modelFit result - this could arise if the modelFit gets further than it does in this case, where an error is thrown in the initial call. But let's do that in another ticket: https://mrc-ide.myjetbrains.com/youtrack/issue/mrc-4680/Display-modelFit.result.error-in-Fit-tab