cannot make linter ignore specific rules

[aspiers]

Even though addons-linter supports disabling specific rules, it seems that there is no way to use this feature when invoking web-ext lint. Based on a very quick glance at the code, maybe fixing this is as simple as adding disableLinterRules here?

web-ext/src/cmd/lint.js

Lines 32 to 48 in 61464c8

	const config = {
	logLevel: verbose ? 'debug' : 'fatal',
	stack: Boolean(verbose),
	pretty,
	privileged,
	warningsAsErrors,
	metadata,
	output,
	boring,
	selfHosted,
	shouldScanFile: (fileName) => fileFilter.wantFile(fileName),
	minManifestVersion: 2,
	maxManifestVersion: 3,
	// This mimics the first command line argument from yargs, which should be
	// the directory to the extension.
	_: [sourceDir],
	};

The only workaround seems to be to ignore whole files, but this is undesirable for the same reason it's undesirable in other linters like eslint: it runs the risk of missing other rule violations in the ignored file.

[Rob--W]

We're supportive of a way to ignore specific rules. Patches are welcome!

[aspiers]

Thanks. Do you happen to know if my surface-deep assessment above is along the right lines?

[Rob--W]

Thanks. Do you happen to know if my surface-deep assessment above is along the right lines?

Looks reasonable. The config will be read and forwarded internally by https://github.com/mozilla/addons-linter/blob/c5a1c2c73a44935451628bba5e3d1249cbdfad27/src/linter.js#L430