From 5efb9349adb72cecdbc7bcb9522e0dc1183a83eb Mon Sep 17 00:00:00 2001 From: Francesco Lodolo Date: Mon, 6 Jan 2025 18:24:00 +0100 Subject: [PATCH] Use 'fas' instead of 'fa' for Font Awesome (#3509) Also: Fix unreviewed (lightbulb) icon alignment --- pontoon/administration/templates/admin.html | 2 +- pontoon/base/static/css/check-box.css | 2 +- pontoon/base/static/css/download_selector.css | 6 ++--- pontoon/base/static/css/heading_info.css | 9 ++++--- pontoon/base/static/css/style.css | 26 +++++++++---------- pontoon/base/static/css/table.css | 6 ++--- pontoon/base/static/js/table.js | 2 +- pontoon/base/templates/django/base.html | 20 +++++++------- .../socialaccount/authentication_error.html | 2 +- pontoon/base/templates/header.html | 16 ++++++------ pontoon/base/templates/no_projects.html | 2 +- pontoon/base/templates/widgets/checkbox.html | 2 +- .../base/templates/widgets/heading_info.html | 6 ++--- .../templates/widgets/item_selector_list.html | 4 +-- pontoon/base/templates/widgets/menu.html | 2 +- pontoon/base/templates/widgets/priority.html | 2 +- pontoon/base/templates/widgets/profile.html | 2 +- .../templates/widgets/progress_chart.html | 2 +- .../base/templates/widgets/theme_toggle.html | 4 +-- .../contributors/static/css/contributors.css | 2 +- pontoon/contributors/static/css/settings.css | 4 +-- .../templates/contributors/profile.html | 26 +++++++++---------- .../widgets/contributor_selector_list.html | 4 +-- .../widgets/notifications_menu.html | 2 +- pontoon/homepage/static/css/homepage.css | 2 +- pontoon/homepage/templates/homepage.html | 2 +- .../homepage/templates/homepage_content.html | 2 +- .../insights/static/css/insights_charts.css | 6 ++--- .../templates/insights/widgets/tooltip.html | 2 +- .../localizations/includes/resources.html | 2 +- .../localizations/includes/tags.html | 2 +- .../localizations/widgets/resource_list.html | 12 ++++----- .../templates/machinery/machinery.html | 4 +-- pontoon/messaging/static/css/messaging.css | 4 +-- .../templates/messaging/includes/compose.html | 8 +++--- .../templates/messaging/includes/sent.html | 4 +-- .../templates/projects/includes/tags.html | 2 +- .../templates/projects/includes/teams.html | 4 +-- .../projects/templates/projects/projects.html | 2 +- .../projects/widgets/project_list.html | 18 ++++++------- pontoon/sync/templates/sync/log_list.html | 4 +-- .../tags/templates/tags/widgets/tag_list.html | 10 +++---- pontoon/teams/static/css/info.css | 2 +- pontoon/teams/static/css/team.css | 2 +- .../teams/static/css/translation_memory.css | 12 ++++----- pontoon/teams/static/js/bugzilla.js | 8 +++--- pontoon/teams/static/js/request.js | 2 +- .../teams/templates/teams/includes/info.html | 2 +- .../templates/teams/includes/permissions.html | 6 ++--- .../templates/teams/includes/projects.html | 6 ++--- .../teams/includes/translation_memory.html | 8 +++--- pontoon/teams/templates/teams/teams.html | 4 +-- .../templates/teams/widgets/team_list.html | 14 +++++----- .../teams/widgets/team_selector.html | 2 +- .../teams/widgets/team_selector_list.html | 4 +-- .../widgets/translation_memory_entries.html | 10 +++---- .../components/ApproveAll.test.js | 8 +++--- .../batchactions/components/ApproveAll.tsx | 2 +- .../batchactions/components/BatchActions.css | 4 +-- .../batchactions/components/BatchActions.tsx | 6 ++--- .../batchactions/components/RejectAll.test.js | 8 +++--- .../batchactions/components/RejectAll.tsx | 2 +- .../components/ReplaceAll.test.js | 8 +++--- .../batchactions/components/ReplaceAll.tsx | 2 +- .../comments/components/AddComment.tsx | 2 +- .../modules/comments/components/Comment.css | 2 +- .../modules/comments/components/Comment.tsx | 2 +- .../editor/components/EditorMainAction.tsx | 2 +- .../modules/editor/components/EditorMenu.css | 2 +- .../editor/components/EditorSettings.css | 6 ++--- .../editor/components/EditorSettings.tsx | 6 ++--- .../entitieslist/components/EntitiesList.css | 4 +-- .../entitieslist/components/EntitiesList.tsx | 6 ++--- .../entitieslist/components/Entity.css | 2 +- .../entitieslist/components/Entity.tsx | 4 +-- .../components/EntityNavigation.css | 2 +- .../components/EntityNavigation.tsx | 8 +++--- .../history/components/HistoryTranslation.css | 2 +- .../history/components/HistoryTranslation.tsx | 18 ++++++------- .../loaders/components/SkeletonLoader.tsx | 2 +- .../machinery/components/Machinery.tsx | 6 ++--- .../components/MachineryTranslation.tsx | 2 +- .../components/source/GoogleTranslation.tsx | 2 +- .../project/components/ProjectMenu.tsx | 6 ++--- .../projectinfo/components/ProjectInfo.tsx | 2 +- .../resource/components/ResourceMenu.tsx | 6 ++--- .../search/components/FiltersPanel.css | 10 ++++--- .../search/components/FiltersPanel.tsx | 20 ++++++++------ .../modules/search/components/SearchBox.css | 6 ++--- .../modules/search/components/SearchPanel.css | 6 ++--- .../modules/search/components/SearchPanel.tsx | 8 +++--- .../search/components/TimeRangeFilter.css | 2 +- .../search/components/TimeRangeFilter.tsx | 4 +-- .../modules/user/components/FileUpload.tsx | 2 +- .../src/modules/user/components/UserMenu.css | 2 +- .../src/modules/user/components/UserMenu.tsx | 26 +++++++++---------- .../user/components/UserNotificationsMenu.tsx | 2 +- 97 files changed, 278 insertions(+), 271 deletions(-) diff --git a/pontoon/administration/templates/admin.html b/pontoon/administration/templates/admin.html index 00023ba0c4..b771f43089 100644 --- a/pontoon/administration/templates/admin.html +++ b/pontoon/administration/templates/admin.html @@ -15,7 +15,7 @@
- +
Add new project diff --git a/pontoon/base/static/css/check-box.css b/pontoon/base/static/css/check-box.css index dc422df264..e2a740c526 100644 --- a/pontoon/base/static/css/check-box.css +++ b/pontoon/base/static/css/check-box.css @@ -34,7 +34,7 @@ color: var(--white-1); } - .fa { + .fas { margin-left: 23px; margin-right: 0; } diff --git a/pontoon/base/static/css/download_selector.css b/pontoon/base/static/css/download_selector.css index c138fe15df..d5912c898e 100644 --- a/pontoon/base/static/css/download_selector.css +++ b/pontoon/base/static/css/download_selector.css @@ -7,7 +7,7 @@ padding-top: 0; } -.download-selector .selector .fa { +.download-selector .selector .fas { float: right; background: var(--button-background-2); border-radius: 3px; @@ -20,11 +20,11 @@ text-align: center; } -.download-selector .selector .fa:hover { +.download-selector .selector .fas:hover { background: var(--button-background-hover-2); } -.download-selector.opened .selector .fa { +.download-selector.opened .selector .fas { background: var(--button-background-hover-2); border-radius: 2px 2px 0 0; } diff --git a/pontoon/base/static/css/heading_info.css b/pontoon/base/static/css/heading_info.css index f565d6824e..dfa549406f 100644 --- a/pontoon/base/static/css/heading_info.css +++ b/pontoon/base/static/css/heading_info.css @@ -130,7 +130,7 @@ ul { color: var(--status-translated); } -#heading .legend li .status.fa { +#heading .legend li .status.fas { left: 0; top: 4px; } @@ -176,17 +176,18 @@ ul { padding-bottom: 21px; } -#heading .non-plottable .unreviewed .status.fa { +#heading .non-plottable .unreviewed .status.fas { left: auto; position: relative; top: -1px; + left: -0.5px; } -#heading .non-plottable .unreviewed .status.fa:before { +#heading .non-plottable .unreviewed .status.fas:before { color: var(--icon-background-2); font-size: 18px; } -#heading .non-plottable .unreviewed.pending .status.fa:before { +#heading .non-plottable .unreviewed.pending .status.fas:before { color: var(--status-unreviewed); } diff --git a/pontoon/base/static/css/style.css b/pontoon/base/static/css/style.css index 807f6f1934..1f29f6aa5a 100755 --- a/pontoon/base/static/css/style.css +++ b/pontoon/base/static/css/style.css @@ -9,35 +9,35 @@ font-size: 0.9em; } -.status.fa { +.status.fas { font-size: 16px; left: 20px; position: absolute; top: 3px; } -.status.fa:before { +.status.fas:before { color: var(--status-missing); content: ''; } -.translated .status.fa:before { +.translated .status.fas:before { color: var(--status-translated); } -.pretranslated .status.fa:before { +.pretranslated .status.fas:before { color: var(--status-pretranslated); } -.warnings .status.fa:before { +.warnings .status.fas:before { color: var(--status-warning); } -.errors .status.fa:before { +.errors .status.fas:before { color: var(--status-error); } -.unreviewed .status.fa:before { +.unreviewed .status.fas:before { color: var(--status-unreviewed); content: ''; } @@ -81,7 +81,7 @@ button { outline: none; } -/* Reset values for Persian (fa) to avoid colision with Font Awesome */ +/* Reset values for Persian (fa) to avoid collision with Font Awesome */ .language.fa { font-family: inherit; font-weight: inherit; @@ -950,7 +950,7 @@ header .right .select .menu { line-height: 22px; } -#profile .menu li i.fa, +#profile .menu li i.fas, #profile .menu li i.fab { margin: 0 8px 0 -2px; } @@ -1077,7 +1077,7 @@ nav .links li { color: var(--white-1); } -.submenu.tabs .links a .fa { +.submenu.tabs .links a .fas { margin-right: 4px; } @@ -1150,17 +1150,17 @@ body > form, user-select: none; } -.check-box .fa { +.check-box .fas { margin-right: 6px; } -.check-box .fa:before { +.check-box .fas:before { color: var(--toggle-color-1); content: ''; font-weight: normal; } -.check-box.enabled .fa:before { +.check-box.enabled .fas:before { color: var(--status-translated); content: ''; font-weight: bold; diff --git a/pontoon/base/static/css/table.css b/pontoon/base/static/css/table.css index 2c1754b5e6..1f13f60cdf 100644 --- a/pontoon/base/static/css/table.css +++ b/pontoon/base/static/css/table.css @@ -76,7 +76,7 @@ table.table.project-list.hidden { .table .unreviewed-status span { position: absolute; font-size: 18px; - margin: -15px 0 0 -5px; + margin: -15px 0 0 -4.5px; } .table .progress { @@ -152,7 +152,7 @@ table.table.project-list.hidden { padding-left: 15px; } -.table td.priority .fa { +.table td.priority .fas { margin-left: -1px; font-size: 12px; } @@ -276,7 +276,7 @@ table.table.project-list.hidden { color: var(--icon-background-1); font-size: 18px; position: absolute; - right: 0; + right: 0.5px; top: -9px; } diff --git a/pontoon/base/static/js/table.js b/pontoon/base/static/js/table.js index 9c64ff2bde..e693da80d8 100644 --- a/pontoon/base/static/js/table.js +++ b/pontoon/base/static/js/table.js @@ -37,7 +37,7 @@ $('body') $element.after( '