Skip to content
This repository has been archived by the owner on Jan 29, 2025. It is now read-only.

Remove schemaVersion from test recipes #186

Open
jaredlockhart opened this issue Dec 6, 2021 · 1 comment
Open

Remove schemaVersion from test recipes #186

jaredlockhart opened this issue Dec 6, 2021 · 1 comment

Comments

@jaredlockhart
Copy link
Contributor

Since the schemaVersion in test recipes will not be known when test data is written, anything we write in that field will be wrong, so maybe we should omit it from the test recipes altogether? We need to verify that clients don't depend on that field in any way first.

@lmorchard
Copy link

Looks like schemaVersion is required by the NimbueExperiment type, so when I tried removing it from the example data in my PR, the CI run failed.

Easy fix would be to make it optional in the type along with taking it out of example data, but that goes back to the verifying that clients don't depend on the field.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants