Remove references to "release channel" in Audiences.ts now that channel is parameterized?

[pdehaan]

Looks like the audience descriptions still reference a "release channel" even though we turned that into a variable. Not sure if that is a bug or if it'd only impact us testing locally on Beta/Nightly and no end users would see this.

nimbus-shared/data/Audiences.ts

Line 6 in 9a78bd7

description: "All users in en-* locales using the release channel.",

nimbus-shared/data/Audiences.ts

Line 13 in 9a78bd7

description: "All users in the US with an en-* locale using the release channel.",

nimbus-shared/data/Audiences.ts

Line 22 in 9a78bd7

"First start-up users (e.g. for about:welcome) with an en-* locale using the release channel.",

  us_only: {
    name: "US users (en)",
    description: "All users in the US with an en-* locale using the release channel.",
    targeting:
      "localeLanguageCode == 'en' && region == 'US' && browserSettings.update.channel == '{firefox_channel}'",
    desktop_telemetry:
      "STARTS_WITH(environment.settings.locale, 'en') AND normalized_country_code = 'US'",
  },

Also, I notice that the targeting field references a {firefox_channel}, but I don't see a similar reference to a channel in the desktop_telemetry field. I'll need to peek further into that to see what it was like before we parameterized the channel from a hardcoded "release" string.

[pdehaan]

Also, I notice that the targeting field references a {firefox_channel}, but I don't see a similar reference to a channel in the desktop_telemetry field. I'll need to peek further into that to see what it was like before we parameterized the channel from a hardcoded "release" string.

Looks like this was changed in PR #99. I also added a more context aware question in #99 (comment)