Skip to content
This repository has been archived by the owner on Sep 12, 2018. It is now read-only.

Android build script doesn't work on macOS #749

Open
thomcc opened this issue Jun 18, 2018 · 3 comments
Open

Android build script doesn't work on macOS #749

thomcc opened this issue Jun 18, 2018 · 3 comments

Comments

@thomcc
Copy link
Contributor

thomcc commented Jun 18, 2018

The version of bash it requires is too new. It's possible to request that users install a newer bash but we should probably just make it not require that.

@ncalexan
Copy link
Member

The version of bash it requires is too new. It's possible to request that users install a newer bash but we should probably just make it not require that.

Yes, I agree. I didn't think it actually had a functioning shebang, but maybe that's some other script in there. I've always ran it as bash ... anyway, since I run Fish instead.

@thomcc
Copy link
Contributor Author

thomcc commented Jun 19, 2018

Sadly, running as bash ... still requires a sufficently new bash, which is the bug I'm reporting. I could make it work by updating the version of bash I have installed (and I probably will eventually), but IMO the amount we gain by requiring that is minimal enough not to be worth it.

(FYI since I also use fish, you can still run executable shell scripts with shebangs as ./blah, even if they aren't written in fish).

@grigoryk
Copy link
Contributor

Ah, this is annoying. I used bash 4.0's associative arrays, which I think is what's causing the problem. 4.0 was announced nearly 10 years ago - but apparently since it's licensed under GPLv3, OSX won't include it and instead uses an older GPLv2 version.

We should change the script :(

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants