Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config #19

Merged
merged 12 commits into from
Jan 30, 2025
Merged

Add config #19

merged 12 commits into from
Jan 30, 2025

Conversation

Kostis-S-Z
Copy link
Member

@Kostis-S-Z Kostis-S-Z commented Jan 20, 2025

What's changing

Use Pydantic + yaml to store and parse configurations and hyperparameters for finetuning.

Closes #11

How to test it

Steps to test the changes:

  1. Set your model id, dataset id, language etc in config.yaml
  2. Run python finetune_whisper.py
  3. Verify that the values you set are the ones used by checking the logs

Additional notes for reviewers

Anything you'd like to add to help the reviewer understand the changes you're proposing.

I already...

  • Tested the changes in a working environment to ensure they work as expected
  • Added some tests for any new functionality
  • Updated the documentation (both comments in code and under /docs)

@Kostis-S-Z Kostis-S-Z self-assigned this Jan 22, 2025
@Kostis-S-Z Kostis-S-Z marked this pull request as ready for review January 22, 2025 13:31
@Kostis-S-Z Kostis-S-Z requested a review from daavoo January 22, 2025 13:32
@Kostis-S-Z Kostis-S-Z merged commit 77cff00 into main Jan 30, 2025
2 checks passed
@Kostis-S-Z Kostis-S-Z deleted the add-config branch January 30, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add config file for hyper-parameters
2 participants