Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate the different creation jobs into an organized class/package. #706

Open
njbrake opened this issue Jan 21, 2025 · 0 comments · May be fixed by #740
Open

Consolidate the different creation jobs into an organized class/package. #706

njbrake opened this issue Jan 21, 2025 · 0 comments · May be fixed by #740
Assignees
Labels
api Changes which impact API/presentation layer backend

Comments

@njbrake
Copy link
Contributor

njbrake commented Jan 21, 2025

This issue comes from a comment on a PR about schemas between job and backend.

https://github.com/mozilla-ai/lumigator/pull/692/files/fa86422b1c33d503a786bdc1f8a3e4d840624afd#r1923204888
also
https://github.com/mozilla-ai/lumigator/pull/692/files/fa86422b1c33d503a786bdc1f8a3e4d840624afd#r1923229499

Basically, the different types of Jobs (JobEvalLiteCreate, JobInferenceCreate) could be organized with pydantic descriminators and classes so that when a new job is added, logic to handle the new job would need to be put in as few places as possible.

FYI @javiermtorres since this issue comes out of our discussion about it on the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Changes which impact API/presentation layer backend
Projects
Development

Successfully merging a pull request may close this issue.

2 participants