Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Using OSX Keychain as backend #11

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

WIP: Using OSX Keychain as backend #11

wants to merge 2 commits into from

Conversation

moul
Copy link
Owner

@moul moul commented Mar 24, 2014

Waiting for #10 for total rewrite, this is a working proof-of-concept

Speed is bad but we can think about using Keychain and .gauth file, so the user can choose between speed and improved-security.

cc @golimpio

@moul moul closed this Mar 24, 2014
@moul moul reopened this Mar 24, 2014
@moul
Copy link
Owner Author

moul commented Mar 26, 2014

#10 (comment)

it looks good to me.
I ran a few tests and it worked fine.
It's a bit slower than the config file (like you said), but since it runs a command line for each key, it's expected to be slower any way.
May be using the Using Python Keyring Lib would improve the performance, but it can be investigated for a next version, I think.

👍

@moul
Copy link
Owner Author

moul commented Sep 9, 2015

Too slow, we need to cache the list of keys and only call the slow resolver when asking specifically for a key

@moul moul added freeze and removed ready labels Dec 7, 2016
@moul moul changed the title Using OSX Keychain as backend WIP: Using OSX Keychain as backend Jul 29, 2019
@trafico-bot trafico-bot bot added the freeze label Jul 29, 2019
@moul moul marked this pull request as draft May 26, 2022 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement freeze question 🚧 WIP Still work-in-progress, please don't review and don't merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant