Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with the collate_sbs_results part of collate_results #30

Open
Kdreval opened this issue Dec 18, 2023 · 1 comment
Open

Issues with the collate_sbs_results part of collate_results #30

Kdreval opened this issue Dec 18, 2023 · 1 comment

Comments

@Kdreval
Copy link
Contributor

Kdreval commented Dec 18, 2023

collate_results uses the cached results table by default. This is good because it has preserved mutational signature data that has since gone away (namely the current mutational signature table omits SBS9 which has to be the worst one to omit from GAMBL).

However the sbs_manipulation argument effectively does nothing with the cached results because only SBS1, 8, and 9 have scaled results cached, so all the other mutational signatures have only original data preserved. Also I think expected behavior is that if the user wants scaled data returned, the function should ONLY return scaled data, not scaled + unscaled data in cryptically named columns.

@Kdreval
Copy link
Contributor Author

Kdreval commented Dec 18, 2023

This is a migration of the issue #113 from the parent repo

@Kdreval Kdreval closed this as completed Dec 18, 2023
@Kdreval Kdreval reopened this Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant