Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange comment in MiAbstractBrowser >> canPropagate #1283

Open
NicolasAnquetil opened this issue Dec 28, 2024 · 0 comments
Open

Strange comment in MiAbstractBrowser >> canPropagate #1283

NicolasAnquetil opened this issue Dec 28, 2024 · 0 comments
Assignees

Comments

@NicolasAnquetil
Copy link
Contributor

NicolasAnquetil commented Dec 28, 2024

I don't understand the comment :

MiAbstractBrowser >> canPropagate
"Ideally we should use miSelectedItemToPropagate but this would make the models browser really slow since 
it would copy the whole model and reject the stubs each time I'm called. So we do not care about checking the 
stubs here by calling #miSelectedItem.."

MiAbstractBrowser is the super class of all MooseIDE browsers, filtering out stubs is only done by the ModelsBrowser (if the related setting is activated).
So it seems this comment is not at the right place...
And the implementation of the method should be corrected accordingly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants