Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove EUI Dependency #169

Open
iporollo opened this issue Apr 13, 2022 · 4 comments
Open

Remove EUI Dependency #169

iporollo opened this issue Apr 13, 2022 · 4 comments
Labels
good first issue Good for newcomers react

Comments

@iporollo
Copy link
Contributor

Description

We were originally using the EUI user interface library to build some of our components. We have since switched to the React Bootstrap library, but have not fully removed the EUI dependency (since we are still using some of their components for forms). The EUI dependency has unnecessary second order dependencies such as moment.js that we don't use but make the build heavier

Expected behavior

We need to refactor the forms that use EUI components into Bootstrap forms to fully remove the EUI dependency. Then, we need to delete EUI from the package.json.

Steps to reproduce

  1. Go to Sources or Integrations page
  2. Click on Create Data Source or Create Integration
  3. Notice that the drawer is an EUI component

Additional context

image

image

@iporollo iporollo added good first issue Good for newcomers react labels Apr 13, 2022
@yokaiemporer
Copy link

yokaiemporer commented Apr 13, 2022

@iporollo
Hi, I am a beginner.
should the drawer look the same after it is replaced with react-bootstrap components?

@iporollo
Copy link
Contributor Author

Hi @yokaiemporer! Appreciate you helping out here. Yes, ideally the drawer looks similar to the original one, with the color scheme being the boostrap primary color (purple) rather than the EUI blue.

@unkrich
Copy link
Collaborator

unkrich commented Apr 13, 2022

Here's a link to the react-bootstrap components we're looking to replace it with:
https://react-bootstrap.github.io/forms/overview/

And here's an example in the code where we already use those components for a form:
https://github.com/monosidev/monosi/blob/master/src/ui/src/pages/app/onboarding/GettingStarted/index.tsx

@yokaiemporer
Copy link

Thank you , will try replacing and confirm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers react
Projects
None yet
Development

No branches or pull requests

3 participants