-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fully convert monorepo to bzlmod #343
Comments
This does add some workarounds for e.g. bazelbuild/bazel#19301 |
And to completely remove WORKSPACE we need to wait for rmohr/bazeldnf#60 |
Hmm, that's one more reason to attempt to switch to rules_nixpkgs |
Are we blocked on this? |
No we aren't. It's just not pretty :) |
This does migrate nearly everything to bzlmod and away from the "old" WORKSPACE system. We do have to use some workarounds and there is no good way to get the path to a repository. This definitively requires some more love in future CLs but this should cover the basics. See #343 for more information. Change-Id: I0e188d8708b66fcdbdf0adc9143c93160e3395ae Reviewed-on: https://review.monogon.dev/c/monogon/+/3357 Reviewed-by: Lorenz Brun <[email protected]> Reviewed-by: Leopold Schabel <[email protected]> Tested-by: Jenkins CI
Final piece is figuring out how to replace the hardcoded external repository names (which isn't technically necessary, but Bazel doesn't consider them stable and will change them soon). |
Technically not correct but we will leave it closed as we are currently only waiting for bazeldnf |
Fair enough, the way we use bazeldnf isn't compatible with bzlmod anyways. |
From what I understand about the design, this should allow us to depend on the monorepo from internal.git, while maintaining MVS semantics.
We should also set appropriate visibility rules to make sure we don't unintentionally expose APIs which we later regret.
The text was updated successfully, but these errors were encountered: