Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is MollieGateway compatible with other payment methods of Spree ? #101

Open
nflorentin opened this issue Aug 19, 2021 · 0 comments
Open

Comments

@nflorentin
Copy link

Hi,

I was going to use Mollie for a client project but I'm facing an issue.

If I add other payment methods than Mollie, they don't seem to work well.

For example, If I add Spree::PaymentMethod::Check as a payment method, confirmation emails is not sent and inventory tracking is not done.
I think the problem is caused by the fact that the gem spree-mollie-gateway overrides the finalize! method of Order class (here). This method seems tightly coupled with mollie logic but is also used by every order as soon as the gem is added in the bundle (no matter what payment method is used).

So my question is: Is it possible to activate other payment methods of Spree when using MollieGateway ? If not, that would mean that if I choose Mollie Gateway, I won't be able to activate bank check payment method for example.

Is it not possible to run the code of mollie finalize! method only if the payment method used is Mollie and use the default finalize! method of spree otherwise ?

Thanks in advance for your insight,

Have a nice day

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant