Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update resource pages and helper functions for 10.x name/id changes #2956

Merged
merged 3 commits into from
Nov 10, 2023
Merged

fix: Update resource pages and helper functions for 10.x name/id changes #2956

merged 3 commits into from
Nov 10, 2023

Conversation

connoratrug
Copy link
Contributor

@connoratrug connoratrug commented Nov 10, 2023 •
edited
Loading

Use id where possible and remove name.toLower workarounds

Closes #2947

@connoratrug
fix: Update resource pages and helper functions for 10.x name/id changes
822fbfa 
Use id where possible and remove name.toLower workarounds
@connoratrug connoratrug requested a review from mswertz November 10, 2023 12:31
mswertz
mswertz requested changes Nov 10, 2023
View reviewed changes
Copy link
Member

@mswertz mswertz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you want to use table.label and column.label instead of table.name and column.name?

apps/nuxt3-ssr/interfaces/types.ts Outdated Show resolved Hide resolved
apps/nuxt3-ssr/pages/[schema]/ssr-catalogue/tables.vue Outdated Show resolved Hide resolved
@connoratrug connoratrug requested a review from mswertz November 10, 2023 14:13
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@connoratrug connoratrug merged commit af41786 into master Nov 10, 2023
@connoratrug connoratrug deleted the fix/update-resource-pages-for-10x-release branch November 10, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mswertz mswertz mswertz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tables app fails to load in ssr catalogue
2 participants
@connoratrug @mswertz