Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: setup utils module with type exports and usage example #2944

Merged
merged 3 commits into from
Nov 13, 2023
Merged

chore: setup utils module with type exports and usage example #2944

merged 3 commits into from
Nov 13, 2023

Conversation

connoratrug
Copy link
Contributor

⚠️ to have ts types loaded in for helloworld example in VS code using Volar see: https://vuejs.org/guide/typescript/overview.html#volar-takeover-mode

@connoratrug
chore: add lib functions
0e6df4d 
and extend sample use with function and type import
mswertz
mswertz approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@mswertz mswertz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose as next step have all apps use this (and remove the duplicated code from molgenis-components?)

apps/helloworld/src/App.vue
@@ -1,13 +1,26 @@
<template>
<Molgenis id="__top" v-model="session">
<router-view :session="session" :page="page" />

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newline could be removed

mswertz
mswertz reviewed Nov 10, 2023
View reviewed changes
Copy link
Member

@mswertz mswertz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do notice that some of the 10.x changes are not yet processed, e.g. schemaName instead of schemaId. So next step should be to copy the molgenis-components version into this lib

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@connoratrug connoratrug merged commit 67a7cee into master Nov 13, 2023
3 checks passed
@connoratrug connoratrug deleted the chore/add-ts-utils-module branch November 13, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mswertz mswertz mswertz approved these changes

@chinook25 chinook25 Awaiting requested review from chinook25

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@connoratrug @mswertz