Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add a bunch of new icons to nuxt3-ssr #2924

Merged
merged 5 commits into from
Nov 8, 2023
Merged

Conversation

mswertz
Copy link
Member

@mswertz mswertz commented Nov 7, 2023

No description provided.

Copy link
Contributor

@connoratrug connoratrug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • why are there changes in the lock file ?
  • are all the add icons needed ? is it clear when to use which icon ?
  • do the icons need to be grouped ? ( general ui , catalogue .., or some other grouping)

@mswertz
Copy link
Member Author

mswertz commented Nov 8, 2023

all good questions. The lock file might be indeed an artifact of something else so will remove it to be sure.
I want to discuss with you guys a design system / frontend workshop environment to where useful come up with some more categorisation. But for now these are simply 'options to choose from'. Ideally we would map them to resource types we have and then we could make it much more stricter.

@mswertz mswertz merged commit 4cfba9f into master Nov 8, 2023
@mswertz mswertz deleted the feat/nuxt_icons branch November 8, 2023 09:12
Copy link

sonarqubecloud bot commented Nov 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants