Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add plus for ref inputs #2922

Merged
merged 5 commits into from
Nov 9, 2023
Merged

feat: add plus for ref inputs #2922

merged 5 commits into from
Nov 9, 2023

Conversation

chinook25
Copy link
Contributor

Adds a quick add button for ref inputs (so you don't first need to click show as table)

@chinook25 chinook25 marked this pull request as ready for review November 9, 2023 09:27
Copy link

sonarqubecloud bot commented Nov 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@mswertz mswertz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should not show '+' if you don't have edit permission => for a refTable in another schema we cannot be sure? So I recommend you to only show it if refSchema is empty (or if not empty, not current?)

</ButtonAlt>
<div v-if="canEdit">
<Tooltip value="New entry">
<RowButtonAdd
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should hid '+' if the refTable is NOT current schema (or find a way to quickly find out if we have permission on that other schema).

@chinook25 chinook25 merged commit 8085c75 into master Nov 9, 2023
@chinook25 chinook25 deleted the feat/easier-ref-adding branch November 9, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants