fix: hide link to non existent about route (#3588)

fix: hide link to non existent about route Only show link if about page exists and info in page is describes catalogue Closes #3555
molgenis · Apr 3, 2024 · 602dcd0 · 602dcd0
1 parent 78d453b
commit 602dcd0
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/apps/nuxt3-ssr/components/header/Catalogue.vue b/apps/nuxt3-ssr/components/header/Catalogue.vue
@@ -51,7 +51,7 @@ if (cohortOnly.value) {
     label: "About",
     link: `/${route.params.schema}/ssr-catalogue/${catalogueRouteParam}/about`,
   });
-} else {
+} else if (catalogueRouteParam && catalogueRouteParam !== "all") {
   menu.push({
     label: "About",
     link: `/${route.params.schema}/ssr-catalogue/${catalogueRouteParam}/networks/${catalogueRouteParam}`,

diff --git a/e2e/tests/catalogue/about-link-visibility.spec.ts b/e2e/tests/catalogue/about-link-visibility.spec.ts
@@ -0,0 +1,13 @@
+import { test, expect } from '@playwright/test';
+
+test('should not show about menu item on non catalogue spesific page', async ({ page }) => {
+  await page.goto('/catalogue-demo/ssr-catalogue/all');
+  await page.getByRole('button', { name: 'Accept' }).click();
+  await expect(page.getByRole('link', { name: 'About' })).toHaveCount(0);
+});
+
+test('should show about menu item on catalogue spesific page', async ({ page }) => {
+  await page.goto('/catalogue-demo/ssr-catalogue/IPEC');
+  await page.getByRole('button', { name: 'Accept' }).click();
+  await expect(page.getByRole('link', { name: 'About' })).toHaveCount(1);
+});