11 add visual bing bong when an artist is added to a country #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mold
force-pushed
the
11-add-visual-bing-bong-when-an-artist-is-added-to-a-country
branch
2 times, most recently
from
b8560e7 to
9c9d8be
Compare
Used for the css transform-origin, could also be used for zooming correctly?
- Replace calls to `map.putCountryCount` with `map.addArtists` - Reduce logic in `putCountryCount` by passing better data from `script.js` - flash a country when it gets a new artist!!! wow!
mold
force-pushed
the
11-add-visual-bing-bong-when-an-artist-is-added-to-a-country
branch
from
9c9d8be to
a9bca3b
Compare
fymmot
deleted the
11-add-visual-bing-bong-when-an-artist-is-added-to-a-country
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It a flash rather than a bing bong