Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There is a multitude of compiler warnings #8

Closed
mbeyss opened this issue Apr 14, 2020 · 1 comment
Closed

There is a multitude of compiler warnings #8

mbeyss opened this issue Apr 14, 2020 · 1 comment
Labels
bad Not a bug, but should be fixed

Comments

@mbeyss
Copy link
Contributor

mbeyss commented Apr 14, 2020

  • reorder
  • sign-compare
  • tautological-compare
  • unused-variable / unused-but-set-variable
  • switch

libFluxML should compile without warnings.The tautological-compares might be hard to fix, as they come from auto generated code
mbeyss added a commit that referenced this issue Apr 14, 2020
@mbeyss
fix compiler warnings "tautological compare". This may have effects o…
cbf3917 
…n parsing speed for measurement spec. However I do not expect this to have impact the overall speed in any way.

refs #8
mbeyss added a commit that referenced this issue Apr 14, 2020
@mbeyss
- fix more tautological compares
c3c2fbd 
- make re2c produce warnings
- fix those warnings (adding default targets)

refs #8
mbeyss added a commit that referenced this issue Apr 14, 2020
@mbeyss
fix (almost) all compiler warnings
0f8e6d7 
refs #8
@mbeyss
Copy link
Contributor Author

mbeyss commented Apr 14, 2020

This is fixed, with the exception of an unused variable, which is handled in #10

@mbeyss mbeyss closed this as completed Apr 14, 2020
@mbeyss mbeyss added the bad Not a bug, but should be fixed label Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bad Not a bug, but should be fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mbeyss